Pacth for Delete in BasePeer.java

["Gregorio, Nelson" <Ne...@sonda.com>]

Hi,

I could'nt connect to server for download turbine source for to do diff


cvs login 
(Logging in to cvs -d :pserver:anoncvs@cvs.apache.org)
cvs [login aborted]: connect to cvs.apache.org:2401 failed: Connection timed
out

*****CVS exited normally with code 1*****

Well, I sent patch for BasePeer.java, for delete conditions like as 

delete TableAAA where TableAAA.ColAA > 3 and TableAAA.ColAA < 8 

in method doDelete 


                if ( criteria.containsKey(key) )
                {
                    Criteria.Criterion criterion =
(Criteria.Criterion)criteria.getCriterion(key);
                    criterion.setDB(db);
                    if ( criterion.getComparison().equals(Criteria.CUSTOM) )
                    {
                        whereClause.add( criterion.toString() ); 
                    }
                    else
                    {
                        whereClause.add( criterion.toString() ); 
                    }
                }




 <<BasePeer.java>>  

Re: Pacth for Delete in BasePeer.java

[John McNally <jm...@collab.net>]

> in method doDelete 
> 
> 
>                 if ( criteria.containsKey(key) )
>                 {
>                     Criteria.Criterion criterion =
> (Criteria.Criterion)criteria.getCriterion(key);
>                     criterion.setDB(db);
>                     if ( criterion.getComparison().equals(Criteria.CUSTOM) )
>                     {
>                         whereClause.add( criterion.toString() ); 
>                     }
>                     else
>                     {
>                         whereClause.add( criterion.toString() ); 
>                     }
>                 }
> 
>

why do you have a conditional with both blocks containing the same code?

john mcnally


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>