[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24190: [SPARK-27260][SS] Upgrade to Kafka 2.2.0

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24190: [SPARK-27260][SS] Upgrade to Kafka 2.2.0
URL: https://github.com/apache/spark/pull/24190#discussion_r268459910
 
 

 ##########
 File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
 ##########
 @@ -429,7 +429,8 @@ class KafkaTestUtils(withBrokerProps: Map[String, Object] = Map.empty) extends L
   }
 
   private def waitUntilMetadataIsPropagated(topic: String, partition: Int): Unit = {
-    def isPropagated = server.apis.metadataCache.getPartitionInfo(topic, partition) match {
+    def isPropagated = server.dataPlaneRequestProcessor.metadataCache
 
 Review comment:
   Thank you for review, @srowen . 
   1. This is new, but this is `KafkaServer` API. Only our test code uses `KafkaServer`.
   2. The existing client can talk to Kafka 2.2 cluster. However, in Kafka 2.2.0, there are client-side bug patches, too. Some of them will be released as Kafka 2.1.2 client library in a few month.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org