You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/01/21 21:53:58 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request #5455: Change lib/go-log to always log UTC

rob05c opened a new pull request #5455:
URL: https://github.com/apache/trafficcontrol/pull/5455


   Without this, log time format will be arbitrary dependent on the OS.
   
   This came out of a conversation with our logs team. It's easier for log tools if the prefix format is consistent. We noticed it was different on dev laptops versus production CentOS servers. Because without this fix, the format is arbitrary depending on how the OS reports the timezone to Go.
   
   ATC officially supports CentOS, which appears to report UTC. So this shouldn't change production servers. But it will guarantee the format is always UTC going forward.
   
   Includes tests.
   No docs, log format is not documented.
   No changelog, log format is not documented, and this shouldn't change the supported CentOS behavior.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - library; error logs of all apps using lib/go-log (TO, TM, ORT)
   
   ## What is the best way to verify this PR?
   Run tests. Print a log from lib/go-log on a machine reporting local time, like a laptop, before this fix, verify format is local, build again with this fix, verify time format is UTC.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   Not a bug fix.
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   ## Additional Information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 merged pull request #5455: Change lib/go-log to always log UTC

Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5455:
URL: https://github.com/apache/trafficcontrol/pull/5455


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 merged pull request #5455: Change lib/go-log to always log UTC

Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5455:
URL: https://github.com/apache/trafficcontrol/pull/5455


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org