You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by jaredjstewart <gi...@git.apache.org> on 2016/09/15 21:44:48 UTC
[GitHub] incubator-geode pull request #240: GEODE-1899: Renamed the custom 'clean' ta...
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/incubator-geode/pull/240
GEODE-1899: Renamed the custom 'clean' task to work with Gradle 3.0+
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaredjstewart/incubator-geode feature/GEODE-1899
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #240
----
commit 804a1cabc78357bea13844dd767afcc66a7426af
Author: Jared Stewart <js...@pivotal.io>
Date: 2016-09-15T20:24:34Z
GEODE-1899: Renamed the custom 'clean' task to work with Gradle 3.0+
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-geode pull request #240: GEODE-1899: Renamed
the custom 'clean' ta...
Posted by Jinmei Liao <ji...@pivotal.io>.
Looks harmless. I'll pull this in. Thanks!
On Thu, Sep 15, 2016 at 2:44 PM, jaredjstewart <gi...@git.apache.org> wrote:
> GitHub user jaredjstewart opened a pull request:
>
> https://github.com/apache/incubator-geode/pull/240
>
> GEODE-1899: Renamed the custom 'clean' task to work with Gradle 3.0+
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/jaredjstewart/incubator-geode
> feature/GEODE-1899
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/incubator-geode/pull/240.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #240
>
> ----
> commit 804a1cabc78357bea13844dd767afcc66a7426af
> Author: Jared Stewart <js...@pivotal.io>
> Date: 2016-09-15T20:24:34Z
>
> GEODE-1899: Renamed the custom 'clean' task to work with Gradle 3.0+
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
--
Cheers
Jinmei
[GitHub] incubator-geode pull request #240: GEODE-1899: Renamed the custom 'clean' ta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-geode pull request #240: GEODE-1899: Renamed the custom 'clean' ta...
Posted by Jared Stewart <js...@pivotal.io>.
Thanks Anthony! You should just continue to type ‘gradle clean build’ as you did before.
To give more detail:
Each gradle subproject has its own built-in ‘clean’ task, which will remove the build directory inside of that module (e.g. geode/geode-core/build/). There is also the ‘cleanAll’ task which will remove the build directory from the root project (i.e. geode/build/). The last block of our root build.gradle file declares that ‘cleanAll’ must be run after the ‘clean’ task of any subproject, so whenever you call ‘gradle clean’ it will automatically trigger ‘cleanAll’.
Best,
Jared
> On Sep 15, 2016, at 3:42 PM, Anthony Baker <ab...@pivotal.io> wrote:
>
> Jared, thanks for the contribution!
>
> Just to make sure everyone understands the change: I should now type `gradle cleanAll build` instead of `gradle clean build`?
>
> Anthony
>
>
>> On Sep 15, 2016, at 2:44 PM, jaredjstewart <gi...@git.apache.org> wrote:
>>
>> GitHub user jaredjstewart opened a pull request:
>>
>> https://github.com/apache/incubator-geode/pull/240
>>
>> GEODE-1899: Renamed the custom 'clean' task to work with Gradle 3.0+
>>
>>
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/jaredjstewart/incubator-geode feature/GEODE-1899
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/incubator-geode/pull/240.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>> This closes #240
>>
>> ----
>> commit 804a1cabc78357bea13844dd767afcc66a7426af
>> Author: Jared Stewart <js...@pivotal.io>
>> Date: 2016-09-15T20:24:34Z
>>
>> GEODE-1899: Renamed the custom 'clean' task to work with Gradle 3.0+
>>
>> ----
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working, please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>
Re: [GitHub] incubator-geode pull request #240: GEODE-1899: Renamed the custom 'clean' ta...
Posted by Anthony Baker <ab...@pivotal.io>.
Jared, thanks for the contribution!
Just to make sure everyone understands the change: I should now type `gradle cleanAll build` instead of `gradle clean build`?
Anthony
> On Sep 15, 2016, at 2:44 PM, jaredjstewart <gi...@git.apache.org> wrote:
>
> GitHub user jaredjstewart opened a pull request:
>
> https://github.com/apache/incubator-geode/pull/240
>
> GEODE-1899: Renamed the custom 'clean' task to work with Gradle 3.0+
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/jaredjstewart/incubator-geode feature/GEODE-1899
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/incubator-geode/pull/240.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #240
>
> ----
> commit 804a1cabc78357bea13844dd767afcc66a7426af
> Author: Jared Stewart <js...@pivotal.io>
> Date: 2016-09-15T20:24:34Z
>
> GEODE-1899: Renamed the custom 'clean' task to work with Gradle 3.0+
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] incubator-geode issue #240: GEODE-1899: Renamed the custom 'clean' task to w...
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/240
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---