[GitHub] vongosling commented on a change in pull request #312: [ISSUE#311] Improve broker register topicrouter info performance

[GitBox <gi...@apache.org>]

vongosling commented on a change in pull request #312: [ISSUE#311] Improve broker register topicrouter info performance
URL: https://github.com/apache/rocketmq/pull/312#discussion_r190172062
 
 

 ##########
 File path: common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
 ##########
 @@ -136,6 +136,16 @@
 
     private boolean forceRegister = false;
 
+    /**
+     *
+     * This configurable item defines interval of topics registration of broker to name server. Allowing values are
+     * between 10, 000 and 60, 000 milliseconds.
+     *
+     * If set to 0, newly created topics will be immediately reported to name servers and interval of periodical
+     * registration defaults to 10, 000 in milliseconds.
+     */
+    private int registerNameServerPeriod = 1000 * 30;
 
 Review comment:
   registerNameServerPeriod is not a good name, maybe aliveICheckInterval is better. Another, do we need to polish here if no changes in a long time?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services