You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/09/22 01:20:06 UTC
[GitHub] [echarts] pissang opened a new pull request #15761: chore: update download links in announcement email template
pissang opened a new pull request #15761:
URL: https://github.com/apache/echarts/pull/15761
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [x] others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15761: chore: update download links in announcement email template
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15761:
URL: https://github.com/apache/echarts/pull/15761#issuecomment-924565735
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #15761: chore: update download links in announcement email template
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #15761:
URL: https://github.com/apache/echarts/pull/15761#discussion_r713569325
##########
File path: build/source-release/template/announce-release.tpl
##########
@@ -13,9 +13,9 @@ The Apache ECharts team is proud to announce Apache ECharts {{ECHARTS_RELEASE_VE
Apache ECharts is a powerful, interactive charting and data visualization library for browser.
-Download Links: https://dist.apache.org/repos/dist/release/echarts/{{ECHARTS_RELEASE_VERSION}}/
+Download Links: https://echarts.apache.org/download.html
-Release Notes: http://www.apache.org/dist/echarts/{{ECHARTS_RELEASE_VERSION}}/RELEASE_NOTE.txt
+Release Notes: https://echarts.apache.org/changelog.html
Website: http://echarts.apache.org/
Review comment:
Thanks for the correction!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #15761: chore: update download links in announcement email template
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #15761:
URL: https://github.com/apache/echarts/pull/15761#discussion_r713569768
##########
File path: build/source-release/template/announce-release.tpl
##########
@@ -13,9 +13,9 @@ The Apache ECharts team is proud to announce Apache ECharts {{ECHARTS_RELEASE_VE
Apache ECharts is a powerful, interactive charting and data visualization library for browser.
-Download Links: https://dist.apache.org/repos/dist/release/echarts/{{ECHARTS_RELEASE_VERSION}}/
+Download Links: https://echarts.apache.org/download.html
-Release Notes: http://www.apache.org/dist/echarts/{{ECHARTS_RELEASE_VERSION}}/RELEASE_NOTE.txt
+Release Notes: https://echarts.apache.org/changelog.html
Website: http://echarts.apache.org/
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #15761: chore: update download links in announcement email template
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #15761:
URL: https://github.com/apache/echarts/pull/15761#discussion_r713564158
##########
File path: build/source-release/template/announce-release.tpl
##########
@@ -13,9 +13,9 @@ The Apache ECharts team is proud to announce Apache ECharts {{ECHARTS_RELEASE_VE
Apache ECharts is a powerful, interactive charting and data visualization library for browser.
-Download Links: https://dist.apache.org/repos/dist/release/echarts/{{ECHARTS_RELEASE_VERSION}}/
+Download Links: https://echarts.apache.org/download.html
-Release Notes: http://www.apache.org/dist/echarts/{{ECHARTS_RELEASE_VERSION}}/RELEASE_NOTE.txt
+Release Notes: https://echarts.apache.org/changelog.html
Website: http://echarts.apache.org/
Review comment:
BTW, I think it would be better to use https.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #15761: chore: update download links in announcement email template
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #15761:
URL: https://github.com/apache/echarts/pull/15761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #15761: chore: update download links in announcement email template
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #15761:
URL: https://github.com/apache/echarts/pull/15761#discussion_r713569325
##########
File path: build/source-release/template/announce-release.tpl
##########
@@ -13,9 +13,9 @@ The Apache ECharts team is proud to announce Apache ECharts {{ECHARTS_RELEASE_VE
Apache ECharts is a powerful, interactive charting and data visualization library for browser.
-Download Links: https://dist.apache.org/repos/dist/release/echarts/{{ECHARTS_RELEASE_VERSION}}/
+Download Links: https://echarts.apache.org/download.html
-Release Notes: http://www.apache.org/dist/echarts/{{ECHARTS_RELEASE_VERSION}}/RELEASE_NOTE.txt
+Release Notes: https://echarts.apache.org/changelog.html
Website: http://echarts.apache.org/
Review comment:
Thanks for the correction! Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15761: chore: update download links in announcement email template
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15761:
URL: https://github.com/apache/echarts/pull/15761#issuecomment-924505056
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org