[GitHub] [accumulo] dlmarion commented on a diff in pull request #3083: Allow user to enable FSDataOutputStream.setDropBehind on majc output

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #3083:
URL: https://github.com/apache/accumulo/pull/3083#discussion_r1042179387


##########
core/src/main/java/org/apache/accumulo/core/file/rfile/RFileOperations.java:
##########
@@ -129,7 +136,23 @@ protected FileSKVWriter openWriter(FileOptions options) throws IOException {
       String file = options.getFilename();
       FileSystem fs = options.getFileSystem();
 
-      outputStream = fs.create(new Path(file), false, bufferSize, (short) rep, block);
+      if (options.dropCacheBehind) {
+        EnumSet<CreateFlag> set = EnumSet.of(CreateFlag.SYNC_BLOCK, CreateFlag.CREATE);
+        outputStream = fs.create(new Path(file), FsPermission.getDefault(), set, bufferSize,

Review Comment:
   I'll look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org