You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org> on 2018/07/16 22:43:21 UTC
Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS
sync for owner privileges.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/
-----------------------------------------------------------
Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
Bugs: SENTRY-2233
https://issues.apache.org/jira/browse/SENTRY-2233
Repository: sentry
Description
-------
Add tests to verify owner privileges are synchronized to HDFS ACL's where owner can be a role/user.
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java e730dd583ac8521ffae4576c63226cabd35cabcc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java 9535dee395162687de2a4b4354f75080a5562635
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java f70b6abd3d95a2b2e5995648c112600108421652
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java 8a1021426d72eb5f282975963357a553d79d0a48
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java c8fc019ec35164b704c1570553d6fc6d561ff525
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b4f4da0c89e00d002d95956521d014ad6c99ddc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 061900a4bd4d53532957e4fccddd5054c6022a0b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20
Diff: https://reviews.apache.org/r/67934/diff/1/
Testing
-------
Added tests to verify HDFS ACL for owner privileges.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS
sync for owner privileges.
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/#review207759
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
Line 431 (original), 456 (patched)
<https://reviews.apache.org/r/67934/#comment291261>
It seems your code is not update to date.
We don't have function verifyTablePrivilegeExistForUser, instead we have verifyTableOwnerPrivilegeExistForPrincipal now.
- Na Li
On Aug. 15, 2018, 6:16 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67934/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2018, 6:16 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2233
> https://issues.apache.org/jira/browse/SENTRY-2233
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add tests to verify owner privileges are synchronized to HDFS ACL's where owner can be a role/user.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java e730dd583ac8521ffae4576c63226cabd35cabcc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java 9535dee395162687de2a4b4354f75080a5562635
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java f70b6abd3d95a2b2e5995648c112600108421652
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java 8a1021426d72eb5f282975963357a553d79d0a48
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java c8fc019ec35164b704c1570553d6fc6d561ff525
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b4f4da0c89e00d002d95956521d014ad6c99ddc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 061900a4bd4d53532957e4fccddd5054c6022a0b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20
>
>
> Diff: https://reviews.apache.org/r/67934/diff/2/
>
>
> Testing
> -------
>
> Added tests to verify HDFS ACL for owner privileges.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS
sync for owner privileges.
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/#review207766
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
Lines 893 (patched)
<https://reviews.apache.org/r/67934/#comment291273>
should this be verifyGroupPermOnAllSubDirs?
- Na Li
On Aug. 22, 2018, 6:33 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67934/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2018, 6:33 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2233
> https://issues.apache.org/jira/browse/SENTRY-2233
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add tests to verify owner privileges are synchronized to HDFS ACL's where owner can be a role/user.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java e730dd583ac8521ffae4576c63226cabd35cabcc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java 9535dee395162687de2a4b4354f75080a5562635
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java f70b6abd3d95a2b2e5995648c112600108421652
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java c085a0cd1c364f7572797d65e5f054eac3c9ce8c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java c2ccb24d304cec9dc6f56642ee13fc9a06e9c19a
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java c8fc019ec35164b704c1570553d6fc6d561ff525
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java f0cf9604893c9c1a3b291e3b7b535bc144d36467
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 061900a4bd4d53532957e4fccddd5054c6022a0b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20
>
>
> Diff: https://reviews.apache.org/r/67934/diff/3/
>
>
> Testing
> -------
>
> Added tests to verify HDFS ACL for owner privileges.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS
sync for owner privileges.
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/#review207769
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Aug. 22, 2018, 8:38 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67934/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2018, 8:38 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2233
> https://issues.apache.org/jira/browse/SENTRY-2233
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add tests to verify owner privileges are synchronized to HDFS ACL's where owner can be a role/user.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java e730dd583ac8521ffae4576c63226cabd35cabcc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java 9535dee395162687de2a4b4354f75080a5562635
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java f70b6abd3d95a2b2e5995648c112600108421652
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java c085a0cd1c364f7572797d65e5f054eac3c9ce8c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java c2ccb24d304cec9dc6f56642ee13fc9a06e9c19a
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java c8fc019ec35164b704c1570553d6fc6d561ff525
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java f0cf9604893c9c1a3b291e3b7b535bc144d36467
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 061900a4bd4d53532957e4fccddd5054c6022a0b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20
>
>
> Diff: https://reviews.apache.org/r/67934/diff/4/
>
>
> Testing
> -------
>
> Added tests to verify HDFS ACL for owner privileges.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS
sync for owner privileges.
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/
-----------------------------------------------------------
(Updated Aug. 22, 2018, 8:38 p.m.)
Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
Changes
-------
addressed review comment.
Bugs: SENTRY-2233
https://issues.apache.org/jira/browse/SENTRY-2233
Repository: sentry
Description
-------
Add tests to verify owner privileges are synchronized to HDFS ACL's where owner can be a role/user.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java e730dd583ac8521ffae4576c63226cabd35cabcc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java 9535dee395162687de2a4b4354f75080a5562635
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java f70b6abd3d95a2b2e5995648c112600108421652
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java c085a0cd1c364f7572797d65e5f054eac3c9ce8c
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java c2ccb24d304cec9dc6f56642ee13fc9a06e9c19a
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java c8fc019ec35164b704c1570553d6fc6d561ff525
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java f0cf9604893c9c1a3b291e3b7b535bc144d36467
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 061900a4bd4d53532957e4fccddd5054c6022a0b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20
Diff: https://reviews.apache.org/r/67934/diff/4/
Changes: https://reviews.apache.org/r/67934/diff/3-4/
Testing
-------
Added tests to verify HDFS ACL for owner privileges.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS
sync for owner privileges.
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/
-----------------------------------------------------------
(Updated Aug. 22, 2018, 6:33 p.m.)
Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
Changes
-------
rebased the patch. Tests are not complete yet.
Bugs: SENTRY-2233
https://issues.apache.org/jira/browse/SENTRY-2233
Repository: sentry
Description
-------
Add tests to verify owner privileges are synchronized to HDFS ACL's where owner can be a role/user.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java e730dd583ac8521ffae4576c63226cabd35cabcc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java 9535dee395162687de2a4b4354f75080a5562635
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java f70b6abd3d95a2b2e5995648c112600108421652
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java c085a0cd1c364f7572797d65e5f054eac3c9ce8c
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java c2ccb24d304cec9dc6f56642ee13fc9a06e9c19a
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java c8fc019ec35164b704c1570553d6fc6d561ff525
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java f0cf9604893c9c1a3b291e3b7b535bc144d36467
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 061900a4bd4d53532957e4fccddd5054c6022a0b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20
Diff: https://reviews.apache.org/r/67934/diff/3/
Changes: https://reviews.apache.org/r/67934/diff/2-3/
Testing
-------
Added tests to verify HDFS ACL for owner privileges.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS
sync for owner privileges.
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/
-----------------------------------------------------------
(Updated Aug. 15, 2018, 6:16 p.m.)
Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
Changes
-------
Addressed review comments.
Bugs: SENTRY-2233
https://issues.apache.org/jira/browse/SENTRY-2233
Repository: sentry
Description
-------
Add tests to verify owner privileges are synchronized to HDFS ACL's where owner can be a role/user.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java e730dd583ac8521ffae4576c63226cabd35cabcc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java 9535dee395162687de2a4b4354f75080a5562635
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java f70b6abd3d95a2b2e5995648c112600108421652
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java 8a1021426d72eb5f282975963357a553d79d0a48
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java c8fc019ec35164b704c1570553d6fc6d561ff525
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b4f4da0c89e00d002d95956521d014ad6c99ddc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 061900a4bd4d53532957e4fccddd5054c6022a0b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20
Diff: https://reviews.apache.org/r/67934/diff/2/
Changes: https://reviews.apache.org/r/67934/diff/1-2/
Testing
-------
Added tests to verify HDFS ACL for owner privileges.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS
sync for owner privileges.
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
> On July 17, 2018, 7:51 p.m., Na Li wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
> > Lines 511 (patched)
> > <https://reviews.apache.org/r/67934/diff/1/?file=2059728#file2059728line511>
> >
> > should you use MANAGED_PREFIXES instead of hardcode the prefix?
>
> kalyan kumar kalvagadda wrote:
> will update it.
Ideally we should be using the warehouse directoy not MANAGED_PREFIXES as the test only created hive managed objects at default warehouse location.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/#review206162
-----------------------------------------------------------
On July 16, 2018, 10:43 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67934/
> -----------------------------------------------------------
>
> (Updated July 16, 2018, 10:43 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2233
> https://issues.apache.org/jira/browse/SENTRY-2233
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add tests to verify owner privileges are synchronized to HDFS ACL's where owner can be a role/user.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java e730dd583ac8521ffae4576c63226cabd35cabcc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java 9535dee395162687de2a4b4354f75080a5562635
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java f70b6abd3d95a2b2e5995648c112600108421652
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java 8a1021426d72eb5f282975963357a553d79d0a48
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java c8fc019ec35164b704c1570553d6fc6d561ff525
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b4f4da0c89e00d002d95956521d014ad6c99ddc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 061900a4bd4d53532957e4fccddd5054c6022a0b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20
>
>
> Diff: https://reviews.apache.org/r/67934/diff/1/
>
>
> Testing
> -------
>
> Added tests to verify HDFS ACL for owner privileges.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS
sync for owner privileges.
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
> On July 17, 2018, 7:51 p.m., Na Li wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
> > Lines 495 (patched)
> > <https://reviews.apache.org/r/67934/diff/1/?file=2059728#file2059728line495>
> >
> > the comment should specify it only verifies owner privilege as it assumes the FsAction.ALL
Will update it.
> On July 17, 2018, 7:51 p.m., Na Li wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
> > Lines 510 (patched)
> > <https://reviews.apache.org/r/67934/diff/1/?file=2059728#file2059728line510>
> >
> > is it possible dbName is null? for example, user has all privilege on server.
dbName will not be null as server privilges are not translated to HDFS ACL's.
> On July 17, 2018, 7:51 p.m., Na Li wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
> > Lines 511 (patched)
> > <https://reviews.apache.org/r/67934/diff/1/?file=2059728#file2059728line511>
> >
> > should you use MANAGED_PREFIXES instead of hardcode the prefix?
will update it.
- kalyan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/#review206162
-----------------------------------------------------------
On July 16, 2018, 10:43 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67934/
> -----------------------------------------------------------
>
> (Updated July 16, 2018, 10:43 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2233
> https://issues.apache.org/jira/browse/SENTRY-2233
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add tests to verify owner privileges are synchronized to HDFS ACL's where owner can be a role/user.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java e730dd583ac8521ffae4576c63226cabd35cabcc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java 9535dee395162687de2a4b4354f75080a5562635
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java f70b6abd3d95a2b2e5995648c112600108421652
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java 8a1021426d72eb5f282975963357a553d79d0a48
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java c8fc019ec35164b704c1570553d6fc6d561ff525
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b4f4da0c89e00d002d95956521d014ad6c99ddc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 061900a4bd4d53532957e4fccddd5054c6022a0b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20
>
>
> Diff: https://reviews.apache.org/r/67934/diff/1/
>
>
> Testing
> -------
>
> Added tests to verify HDFS ACL for owner privileges.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS
sync for owner privileges.
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/#review206162
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
Lines 495 (patched)
<https://reviews.apache.org/r/67934/#comment289075>
the comment should specify it only verifies owner privilege as it assumes the FsAction.ALL
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
Lines 510 (patched)
<https://reviews.apache.org/r/67934/#comment289074>
is it possible dbName is null? for example, user has all privilege on server.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
Lines 511 (patched)
<https://reviews.apache.org/r/67934/#comment289073>
should you use MANAGED_PREFIXES instead of hardcode the prefix?
- Na Li
On July 16, 2018, 10:43 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67934/
> -----------------------------------------------------------
>
> (Updated July 16, 2018, 10:43 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
>
>
> Bugs: SENTRY-2233
> https://issues.apache.org/jira/browse/SENTRY-2233
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add tests to verify owner privileges are synchronized to HDFS ACL's where owner can be a role/user.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java e730dd583ac8521ffae4576c63226cabd35cabcc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java 9535dee395162687de2a4b4354f75080a5562635
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java f70b6abd3d95a2b2e5995648c112600108421652
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java 8a1021426d72eb5f282975963357a553d79d0a48
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java c8fc019ec35164b704c1570553d6fc6d561ff525
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 9b4f4da0c89e00d002d95956521d014ad6c99ddc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java 061900a4bd4d53532957e4fccddd5054c6022a0b
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20
>
>
> Diff: https://reviews.apache.org/r/67934/diff/1/
>
>
> Testing
> -------
>
> Added tests to verify HDFS ACL for owner privileges.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>