[GitHub] john-bodley commented on a change in pull request #6718: Removing uniqueness constraints on tables table

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #6718: Removing uniqueness constraints on tables table
URL: https://github.com/apache/incubator-superset/pull/6718#discussion_r250812102
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -251,7 +251,6 @@ class SqlaTable(Model, BaseDatasource):
     owner_class = security_manager.user_model
 
     __tablename__ = 'tables'
-    __table_args__ = (UniqueConstraint('database_id', 'table_name'),)
 
 Review comment:
   @agrawaldevesh I'm not sure why we should be removing this uniqueness constraint. I've actually proposed having a more restrictive uniqueness constraint per https://github.com/apache/incubator-superset/pull/5449.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org