[GitHub] [beam] aaltay commented on a change in pull request #14869: [BEAM-12357] improve WithKeys transform to take args, kwargs

[GitBox <gi...@apache.org>]

aaltay commented on a change in pull request #14869:
URL: https://github.com/apache/beam/pull/14869#discussion_r645046746



##########
File path: sdks/python/apache_beam/transforms/util.py
##########
@@ -51,6 +51,7 @@
 from apache_beam.transforms.core import MapTuple
 from apache_beam.transforms.core import ParDo
 from apache_beam.transforms.core import Windowing
+from apache_beam.transforms.core import _fn_takes_side_inputs

Review comment:
       Perhaps we should move `_fn_takes_side_inputs` to util.py now it is used in multiple places and rename it to `fn_takes_side_inputs`?

##########
File path: sdks/python/apache_beam/transforms/util_test.py
##########
@@ -628,6 +628,17 @@ def test_callable_k(self):
       with_keys = pc | util.WithKeys(lambda x: x * x)
     assert_that(with_keys, equal_to([(1, 1), (4, 2), (9, 3)]))
 
+  @staticmethod
+  def _test_args_kwargs_fn(x, multiply, subtract):
+    return x * multiply - subtract
+
+  def test_args_kwargs_k(self):

Review comment:
       Could you add a test case with fn that does not take side inputs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org