You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@camel.apache.org by GitBox <gi...@apache.org> on 2019/01/22 13:55:43 UTC

[GitHub] astefanutti commented on issue #352: Enable status subresource for integration

astefanutti commented on issue #352: Enable status subresource for integration
URL: https://github.com/apache/camel-k/pull/352#issuecomment-456407382
 
 
   > That's great!
   > I've made sure that the operator code doesn't touch the `spec` field, but only the status, but it may be subject to error if we don't enforce this rule. 
   
   I've spent an hour reviewing the entire code to make sure the `spec` field wasn't updated to realize you had done an amazing job ;)!
   
   > Don't you need additional roles for changing the status?
   > E.g. look at here: https://github.com/knative/eventing-sources/blob/518626c9b16f6ad45aef00577fbcf3e249e1a584/config/rbac/rbac_role.yaml#L122
   > 
   > My expectation was that roles were not inherited by subresource.
   
   Ah very good point. Let me add these additional roles...
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services