You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/11 07:25:49 UTC
[GitHub] [airflow] jochenott opened a new issue, #24957: DebugExecutor runs task callbacks twice
jochenott opened a new issue, #24957:
URL: https://github.com/apache/airflow/issues/24957
### Apache Airflow version
2.3.3 (latest released)
### What happened
The DebugExecutor runs the on_failure_callback twice.
This is due to `TaskInstance._run_finished_callback()` being called twice: once implicitly via the (new) call to `ti.run()`, once explicitly again:
https://github.com/apache/airflow/blob/62778bb8648515e9823ace2f48d9a89ec91a6803/airflow/executors/debug_executor.py#L79,L81
This came in to the airflow 2-3 branch via this commit: https://github.com/apache/airflow/commit/13e4a752a5b8d71609c90016b9abfd1f14a99ece
This is not an issue on the main branch, where the explicit call to `TaskInstance._run_finished_callback()` has been removed from the `DebugExecutor`.
### What you think should happen instead
_No response_
### How to reproduce
_No response_
### Operating System
Debian 11
### Versions of Apache Airflow Providers
_No response_
### Deployment
Other
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #24957: DebugExecutor runs task callbacks twice
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24957:
URL: https://github.com/apache/airflow/issues/24957#issuecomment-1180204349
Would you like to fix it maybe @jochenott ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #24957: DebugExecutor runs task callbacks twice
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #24957:
URL: https://github.com/apache/airflow/issues/24957#issuecomment-1419014784
cc @o-nikolas related to https://github.com/apache/airflow/pull/24357 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SwanseN21 commented on issue #24957: DebugExecutor runs task callbacks twice
Posted by "SwanseN21 (via GitHub)" <gi...@apache.org>.
SwanseN21 commented on issue #24957:
URL: https://github.com/apache/airflow/issues/24957#issuecomment-1420275412
> ### Apache Airflow version
>
> 2.3.3 (latest released)
>
> ### What happened
>
> The DebugExecutor runs the on_failure_callback twice.
>
>
>
> This is due to `TaskInstance._run_finished_callback()` being called twice: once implicitly via the (new) call to `ti.run()`, once explicitly again:
>
>
>
> https://github.com/apache/airflow/blob/62778bb8648515e9823ace2f48d9a89ec91a6803/airflow/executors/debug_executor.py#L79,L81
>
>
>
> This came in to the airflow 2-3 branch via this commit: https://github.com/apache/airflow/commit/13e4a752a5b8d71609c90016b9abfd1f14a99ece
>
>
>
> This is not an issue on the main branch, where the explicit call to `TaskInstance._run_finished_callback()` has been removed from the `DebugExecutor`.
>
>
>
> ### What you think should happen instead
>
> _No response_
>
> ### How to reproduce
>
> _No response_
>
> ### Operating System
>
> Debian 11
>
> ### Versions of Apache Airflow Providers
>
> _No response_
>
> ### Deployment
>
> Other
>
> ### Deployment details
>
> _No response_
>
> ### Anything else
>
> _No response_
>
> ### Are you willing to submit PR?
>
> - [ ] Yes I am willing to submit a PR!
>
> ### Code of Conduct
>
> - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on issue #24957: DebugExecutor runs task callbacks twice
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on issue #24957:
URL: https://github.com/apache/airflow/issues/24957#issuecomment-1420188487
> related to #24357 ?
@eladkal, related yeah. My change depended on a previous change in main, but the previous change didn't make it into the 2.3 release branch it seems? From what I can tell everything has always been good in main and still seems to be. I'd say we can close this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed issue #24957: DebugExecutor runs task callbacks twice
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed issue #24957: DebugExecutor runs task callbacks twice
URL: https://github.com/apache/airflow/issues/24957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org