You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/03/03 03:41:05 UTC
[jira] [Commented] (CB-8510) Delete copy&paste between
AndroidWebView and XWalkWebView
[ https://issues.apache.org/jira/browse/CB-8510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344373#comment-14344373 ]
ASF subversion and git services commented on CB-8510:
-----------------------------------------------------
Commit a6da46a00e3f4c5bb334077274e4ac4759295fc2 in cordova-android's branch refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=a6da46a ]
CB-8510 Remove `shouldOverrideUrlLoading` from `CordovaWebViewEngine.Client`.
It's logic that's pretty webview-specific, so it doesn't make sense to
share.
> Delete copy&paste between AndroidWebView and XWalkWebView
> ---------------------------------------------------------
>
> Key: CB-8510
> URL: https://issues.apache.org/jira/browse/CB-8510
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Reporter: Andrew Grieve
> Assignee: Andrew Grieve
>
> Right now there is a lot of copy & paste between the two, and bugs that have been fixed on master have not all made it into XWalkWebView. Copy & paste was a great way to get the concept off the ground, but it would be vastly more maintainable to have it shared in some way.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org