You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "hrsakai (via GitHub)" <gi...@apache.org> on 2023/02/03 02:32:55 UTC

[GitHub] [pulsar-client-node] hrsakai opened a new pull request, #290: Rename binary module_name from Pulsar to pulsar

hrsakai opened a new pull request, #290:
URL: https://github.com/apache/pulsar-client-node/pull/290

   
   ### Motivation
   Currently, we can't use `the npm config argument: --{module_name}_binary_host_mirror` if we want to download binary files through a mirror.
   https://github.com/mapbox/node-pre-gyp/blob/v1.0.9/README.md#download-binary-files-from-a-mirror
   
   This is because npm will use npm_config_**p**ulsar_binary_host_mirror for the environment variable name even if running `npm install pulsar-client --Pulsar_binary_host_mirror=<mirror url>`.
   Therefore, we cant' set mirror url correctly.
   
   
   
   
   ### Modifications
   
   * Rename binary module_name from Pulsar to pulsar
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [ ] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-node] nkurihar merged pull request #290: Rename binary module_name from Pulsar to pulsar

Posted by "nkurihar (via GitHub)" <gi...@apache.org>.
nkurihar merged PR #290:
URL: https://github.com/apache/pulsar-client-node/pull/290


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org