[GitHub] [flink] HuangXingBo commented on a diff in pull request #20756: [FLINK-27929][python] Drop support for python36

[GitBox <gi...@apache.org>]

HuangXingBo commented on code in PR #20756:
URL: https://github.com/apache/flink/pull/20756#discussion_r991762362


##########
flink-python/setup.py:
##########
@@ -316,16 +316,10 @@ def extracted_output_files(base_dir, file_path, output_directory):
                         'python_full_version >= "3.7" and platform_system != "Windows"',
                         'httplib2>=0.19.0,<=0.20.4', apache_flink_libraries_dependency]
 
-    if sys.version_info < (3, 7):
-        # python 3.6 upper and lower limit
-        install_requires.append('numpy>=1.14.3,<1.20')
-        install_requires.append('pandas>=1.0,<1.2.0')
-        install_requires.append('pyarrow>=0.15.1,<7.0.0')
-    else:
-        # python 3.7, 3.8 and 3.9 upper limit and M1 chip lower limit,
-        install_requires.append('numpy>=1.21.4,<1.22.0')
-        install_requires.append('pandas>=1.3.0,<1.4.0')
-        install_requires.append('pyarrow>=5.0.0,<9.0.0')
+    # python 3.7, 3.8 and 3.9 upper limit and M1 chip lower limit,

Review Comment:
   since we drop the support python3.6, we can put these install dependencies in `install_requires` directly.



##########
flink-python/setup.py:
##########
@@ -27,12 +27,12 @@
 
 from setuptools import setup, Extension
 
-if sys.version_info < (3, 6):
-    print("Python versions prior to 3.6 are not supported for PyFlink.",
+if sys.version_info < (3, 7):
+    print("Python versions prior to 3.7 are not supported for PyFlink.",
           file=sys.stderr)
     sys.exit(-1)
-elif sys.version_info.minor == 6:
-    warnings.warn("Python version 3.6 won't be supported for PyFlink after 1.16.")

Review Comment:
   we haven't planned to drop support python3.7



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org