You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/09/19 06:16:58 UTC
[GitHub] [pinot] xiangfu0 opened a new pull request, #11620: Refactor BasicAuthUtils from pinot-core to pinot-common
xiangfu0 opened a new pull request, #11620:
URL: https://github.com/apache/pinot/pull/11620
- Refactor BasicAuthUtils from `pinot-core` to `pinot-common`
- Remove `pinot-core` dependency from` pinot-jdbc-client`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #11620: Refactor BasicAuthUtils from pinot-core to pinot-common
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #11620:
URL: https://github.com/apache/pinot/pull/11620#discussion_r1330335754
##########
pinot-core/src/main/java/org/apache/pinot/core/auth/BasicAuthUtils.java:
##########
@@ -64,21 +61,22 @@ private BasicAuthUtils() {
* @return list of BasicAuthPrincipals
*/
public static List<BasicAuthPrincipal> extractBasicAuthPrincipals(PinotConfiguration configuration, String prefix) {
- String principalNames = configuration.getProperty(prefix);
- Preconditions.checkArgument(StringUtils.isNotBlank(principalNames), "must provide principals");
+ String principalNames = configuration.getProperty(prefix);
Review Comment:
does it make sense to also refactor the rest of the utils into common? putting them in core seems weird to me: is there any situation when the rest of the function util is not utilized together with the common one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on pull request #11620: Refactor BasicAuthUtils from pinot-core to pinot-common
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #11620:
URL: https://github.com/apache/pinot/pull/11620#issuecomment-1725032777
> Seems we do have some scalar functions defined in pinot-core. Is it okay to not include them?
It's ok if we exclude entire `pinot-core`, as the scalar functions won't even be discovered.
The previous issue is that the client wants to register those scaler functions from `pinot-core` but won't be able to find the dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11620: Refactor BasicAuthUtils from pinot-core to pinot-common
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11620:
URL: https://github.com/apache/pinot/pull/11620#issuecomment-1724933249
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11620](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9f40d58) into [master](https://app.codecov.io/gh/apache/pinot/commit/e1236429a709b5af3012bc92f51cc4fbcb12741d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e123642) will **decrease** coverage by `48.57%`.
> The diff coverage is `2.01%`.
```diff
@@ Coverage Diff @@
## master #11620 +/- ##
=============================================
- Coverage 63.05% 14.48% -48.57%
+ Complexity 1105 201 -904
=============================================
Files 2325 2326 +1
Lines 124913 124914 +1
Branches 19146 19146
=============================================
- Hits 78758 18099 -60659
- Misses 40533 105284 +64751
+ Partials 5622 1531 -4091
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-17](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.48% <2.01%> (-48.41%)` | :arrow_down: |
| [java-20](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.48% <2.01%> (-48.57%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.48% <2.01%> (-48.56%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/11620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.48% <2.01%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...broker/broker/ZkBasicAuthAccessControlFactory.java](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL1prQmFzaWNBdXRoQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/pinot/common/auth/BasicAuthUtils.java](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vYXV0aC9CYXNpY0F1dGhVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ller/api/access/BasicAuthAccessControlFactory.java](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvYWNjZXNzL0Jhc2ljQXV0aEFjY2Vzc0NvbnRyb2xGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...er/api/access/ZkBasicAuthAccessControlFactory.java](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvYWNjZXNzL1prQmFzaWNBdXRoQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ava/org/apache/pinot/core/auth/BasicAuthUtils.java](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9hdXRoL0Jhc2ljQXV0aFV0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/pinot/server/access/BasicAuthAccessFactory.java](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VydmVyL2FjY2Vzcy9CYXNpY0F1dGhBY2Nlc3NGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../pinot/server/access/ZkBasicAuthAccessFactory.java](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VydmVyL2FjY2Vzcy9aa0Jhc2ljQXV0aEFjY2Vzc0ZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ava/org/apache/pinot/client/utils/DriverUtils.java](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY2xpZW50cy9waW5vdC1qZGJjLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L3V0aWxzL0RyaXZlclV0aWxzLmphdmE=) | `19.09% <33.33%> (ø)` | |
| [...t/broker/broker/BasicAuthAccessControlFactory.java](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jhc2ljQXV0aEFjY2Vzc0NvbnRyb2xGYWN0b3J5LmphdmE=) | `83.33% <100.00%> (+0.47%)` | :arrow_up: |
... and [1500 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11620/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 merged pull request #11620: Refactor BasicAuthUtils from pinot-core to pinot-common
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #11620:
URL: https://github.com/apache/pinot/pull/11620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org