Re: Review Request: HBASE-3232 : Fix KeyOnlyFilter + Add Value Length

[Ryan Rawson <ry...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1213/#review1922
-----------------------------------------------------------


looks great, i just committed it

- Ryan


On 2010-11-14 18:28:50, Nicolas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1213/
> -----------------------------------------------------------
> 
> (Updated 2010-11-14 18:28:50)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> HBASE-3211 altered filter code to mutate KeyValues. What could go wrong? Well, your scan could mess up because the KVHeap compare functions don't work properly. If we're going to soft mutate KVs in filter code, we also need to soft copy the KV before filtering. This was found while adding the ability to have KeyOnlyFilter have the option to return the Value's length. This is useful for grouping your reduce tasks into equal-sized blocks.
> 
> 
> This addresses bug HBASE-3232.
>     http://issues.apache.org/jira/browse/HBASE-3232
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java 1034646 
>   trunk/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java 1034646 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 1034646 
>   trunk/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java 1034646 
>   trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java 1034646 
>   trunk/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java 1034646 
> 
> Diff: http://review.cloudera.org/r/1213/diff
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Nicolas
> 
>