[GitHub] [camel-karavan] mgubaidullin commented on a diff in pull request #682: Add basic integration and e2e tests, env setup

["mgubaidullin (via GitHub)" <gi...@apache.org>]

mgubaidullin commented on code in PR #682:
URL: https://github.com/apache/camel-karavan/pull/682#discussion_r1140287380


##########
karavan-operator/src/main/java/org/apache/camel/karavan/operator/resource/KaravanRole.java:
##########
@@ -43,7 +43,7 @@ public Role desired(Karavan karavan, Context<Karavan> context) {
                         new PolicyRuleBuilder().withApiGroups("").withResources("secrets", "configmaps").withVerbs("get", "list").build(),
                         new PolicyRuleBuilder().withApiGroups("").withResources("persistentvolumes", "persistentvolumeclaims").withVerbs("get", "list", "watch").build(),
                         new PolicyRuleBuilder().withApiGroups("tekton.dev").withResources("pipelineruns").withVerbs("*").build(),
-                        new PolicyRuleBuilder().withApiGroups("").withResources("pods", "services", "routes", "replicationcontrollers").withVerbs("*").build(),

Review Comment:
   Karavan operator create route for karavan-app. I would suggest to replace with
   `withApiGroups("route.openshift.io").withResources( "routes").withVerbs("*").build()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org