You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/02/06 20:55:02 UTC

[Bug 124197] New: Link button in Hyperlink Toolbar Works Only First Time in Document

https://issues.apache.org/ooo/show_bug.cgi?id=124197

            Bug ID: 124197
        Issue Type: DEFECT
           Summary: Link button in Hyperlink Toolbar Works Only First Time
                    in Document
           Product: Writer
           Version: 4.0.1
          Hardware: PC
                OS: Windows 7
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ui
          Assignee: issues@openoffice.apache.org
          Reporter: bnjroo@gmail.com
                CC: issues@openoffice.apache.org

For example, I want to link the text "Text" to "http://www.text.com"
Highlighting "Text" automatically loads "Text" in the first dropdown box. I
click and drag the URL to the URL box, which populates that box. Then, the Link
button is enabled. The first time I do this in a document, it works flawlessly,
assigning the URL to the text in one click.

However, this is where the bug comes in, any subsequent attempt to use the link
button, on another text that I want to assign a URL, nothing happens. I have to
click the link drop button and select "As Text" in order to complete the link.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
Okay, done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

--- Comment #11 from bnjroo <bn...@gmail.com> ---
Good job ALG & ES
Thanks for your help.
-LW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

--- Comment #2 from bnjroo <bn...@gmail.com> ---
will have to try a desktop video captureā€¦

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

--- Comment #7 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1565724 into trunk:
i124197 allow URL Toolbar to send URLs to the app more than once

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

Edwin Sharp <el...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needmoreinfo
                 CC|                            |elish@apache.org

--- Comment #1 from Edwin Sharp <el...@apache.org> ---
Please attach example.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

--- Comment #3 from bnjroo <bn...@gmail.com> ---
http://youtu.be/v5d-nIbCFts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

--- Comment #10 from Edwin Sharp <el...@apache.org> ---
(In reply to bnjroo from comment #9)
> Noted status change to resolved/fixed. Any timeframe on when this update
> will be available to end user or how to patch?
> 
> Thank you.

Release date of 4.1 unknown to me.
Snapshots are available here:
http://ci.apache.org/projects/openoffice/#win

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

--- Comment #9 from bnjroo <bn...@gmail.com> ---
Noted status change to resolved/fixed. Any timeframe on when this update will
be available to end user or how to patch?

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

Edwin Sharp <el...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|needmoreinfo                |
             Status|UNCONFIRMED                 |CONFIRMED
             Latest|---                         |4.1-dev
    Confirmation on|                            |
     Ever confirmed|0                           |1

--- Comment #4 from Edwin Sharp <el...@apache.org> ---
Thank you bnjroo
Confirmed with
AOO410m1(Build:9750)  -  Rev. 1562493
Rev.1562493
Win 7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ACCEPTED
           Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
                   |g                           |
   Target Milestone|---                         |4.1.0

--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
Works as expected and will not be more risky than before, preparing commit...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124197] Link button in Hyperlink Toolbar Works Only First Time in Document

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124197

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Armin.Le.Grand@me.com

--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
I took a look. This happens because there is a member 'bSend' which is set to
true when the URL gets send to the app. Irritatingly there is no place where it
gets reset to false, except that the toolber gets reconstructed, that cannot be
intended. Tried to find info about 'bSend' in the history, but no hints. It
seems to be intended to not send the URL to the app twice, but even that works
well (stepping over setting it). When thinking about at which conditions to
reset it to false its pretty much every one, so the question is why it exists
at all.
Tried to watch changes to the URL string itself, but that is ineffective. Even
when resetting every time SvxHyperlinkDlg::EnableLink() is called and enables
the Link button it will be reset pretty much all the time.
It may have been used to prevent unwanted endless loops when
SvxHyperlinkDlg::SendToApp triggers something that indirectly triggers some
updates to the URL toolbar and may trigger SvxHyperlinkDlg::SendToApp again,
but then it should be sloved locally.
I tend to remove the bool and ensure that SvxHyperlinkDlg::SendToApp will not
run recursively, testing that...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.