[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache

[GitBox <gi...@apache.org>]

sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072112458


##########
plc4j/api/src/main/java/org/apache/plc4x/java/DefaultPlcDriverManager.java:
##########
@@ -32,19 +34,19 @@
 import java.util.ServiceLoader;
 import java.util.Set;
 
-public class PlcDriverManager {
+public class DefaultPlcDriverManager implements PlcDriverManager, PlcConnectionManager {
 
-    private static final Logger LOGGER = LoggerFactory.getLogger(PlcDriverManager.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(org.apache.plc4x.java.DefaultPlcDriverManager.class);

Review Comment:
   ```suggestion
       private static final Logger LOGGER = LoggerFactory.getLogger(DefaultPlcDriverManager.class);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org