You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tianping526 (via GitHub)" <gi...@apache.org> on 2025/10/13 09:12:07 UTC

[PR] fix(golang): fix data race [rocketmq-clients]

tianping526 opened a new pull request, #1109:
URL: https://github.com/apache/rocketmq-clients/pull/1109

   <!-- Please make sure the target branch is right. In most case, the target branch should be `master`. -->
   
   ### Which Issue(s) This PR Fixes
   
   <!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
   
   Fixes #1014
   
   ### Brief Description
   
   <!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
   
   My project relies on rocketmq-clients, but because DATA RACE cannot pass the test, I submitted this PR to solve related DATA RACE issues.
   
   I submitted a PR before to try to fix this issue, but no one did the code review. #1017
   
   As early as 2022, I discovered the related issue, but it was not fully resolved. #294
   
   Below is the action runs where the DATA RACE issue occurred.
   
   https://github.com/tianping526/eventbridge/actions/runs/18458206403/job/52583549567
   https://github.com/tianping526/eventbridge/actions/runs/18454601980/job/52573824963
   
   ### How Did You Test This Change?
   
   <!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
   
   There is no DATA RACE problem in my project. https://github.com/tianping526/eventbridge/actions/runs/18460110509/job/52589414151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(golang): fix data race [rocketmq-clients]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1109:
URL: https://github.com/apache/rocketmq-clients/pull/1109#issuecomment-3555200934

   This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(golang): fix data race [rocketmq-clients]

Posted by "tianping526 (via GitHub)" <gi...@apache.org>.
tianping526 commented on PR #1109:
URL: https://github.com/apache/rocketmq-clients/pull/1109#issuecomment-3396638249

   @guyinyou @RongtongJin @lizhanhui @lizhimins Could you please review my code when you have a moment?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(golang): fix data race [rocketmq-clients]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1109:
URL: https://github.com/apache/rocketmq-clients/pull/1109#issuecomment-3567214943

   This PR was closed because it has been inactive for 3 days since being marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(golang): fix data race [rocketmq-clients]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #1109: fix(golang): fix data race
URL: https://github.com/apache/rocketmq-clients/pull/1109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org