You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/17 09:39:25 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #1829: nuttx/wireless: add wireless event member length helper
anchao opened a new pull request #1829:
URL: https://github.com/apache/incubator-nuttx/pull/1829
## Summary
nuttx/wireless: add wireless event member length helper
## Impact
N/A
## Testing
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1829: nuttx/wireless: add wireless event member length helper
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1829:
URL: https://github.com/apache/incubator-nuttx/pull/1829#issuecomment-694205301
@anchao please edit all your PRs, follow the three section template and fill each section. It may feel like a chore but it is there to help reviewers and people creating the release notes for each PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1829: nuttx/wireless: add wireless event member length helper
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1829:
URL: https://github.com/apache/incubator-nuttx/pull/1829
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1829: nuttx/wireless: add wireless event member length helper
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1829:
URL: https://github.com/apache/incubator-nuttx/pull/1829#issuecomment-695335944
The change is simple to help people calculate the variant event size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1829: nuttx/wireless: add wireless event member length helper
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1829:
URL: https://github.com/apache/incubator-nuttx/pull/1829#issuecomment-695157610
The real change look reasonable:
```
/*
* A Wireless Event. Contains basically the same data as the ioctl...
*/
#define IW_EV_LEN(field) \
(offsetof(struct iw_event, u) + sizeof(((union iwreq_data *)0)->field))
```
@v01d how about your thinking?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #1829: nuttx/wireless: add wireless event member length helper
Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #1829:
URL: https://github.com/apache/incubator-nuttx/pull/1829#issuecomment-694221068
> @anchao please edit all your PRs, follow the three section template and fill each section. It may feel like a chore but it is there to help reviewers and people creating the release notes for each PR. Try to be as descriptive as possible.
Got, I will update the template later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1829: nuttx/wireless: add wireless event member length helper
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1829:
URL: https://github.com/apache/incubator-nuttx/pull/1829#issuecomment-695215094
Sorry, I don't really have a comment, I have no idea about this part of NuttX
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d edited a comment on pull request #1829: nuttx/wireless: add wireless event member length helper
Posted by GitBox <gi...@apache.org>.
v01d edited a comment on pull request #1829:
URL: https://github.com/apache/incubator-nuttx/pull/1829#issuecomment-694205301
@anchao please edit all your PRs, follow the three section template and fill each section. It may feel like a chore but it is there to help reviewers and people creating the release notes for each PR. Try to be as descriptive as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org