[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

[GitBox <gi...@apache.org>]

xiaohui-sun commented on a change in pull request #4250: SoC - Separate out Tuning from Translator
URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288648096
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionUtils.java
 ##########
 @@ -67,13 +67,22 @@ public static boolean isReferenceName(String key) {
     return key.startsWith("$");
   }
 
-  // get the component name from the reference key
-  // example "$myRule:ALGORITHM:0" -> "myRule:ALGORITHM:0"
-  public static String getComponentName(String key) {
-    if (isReferenceName(key)) return key.substring(1);
+  // Extracts the component key from the reference key
 
 Review comment:
   Thanks for making  the naming more clear!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org