[GitHub] [geode] jchen21 commented on a change in pull request #5689: GEODE-8667: Duplicate online Oplog compaction after offline Oplog compaction

[GitBox <gi...@apache.org>]

jchen21 commented on a change in pull request #5689:
URL: https://github.com/apache/geode/pull/5689#discussion_r535734226



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
##########
@@ -5789,9 +5789,8 @@ boolean needsCompaction() {
       if (((rv / (double) rvHWMtmp) * 100) <= parent.getCompactionThreshold()) {
         return true;
       }
-    } else {

Review comment:
       I have changed `readKrf()` function. So that at the end of this function, when `totalCount` and `totalLiveCount` is updated after reading krf file, it will check if `totalCount` is `0` and `totalLiveCount` is greater than `0`, and update `totalCount` accordingly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org