You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by hg...@apache.org on 2004/02/13 09:46:37 UTC
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_vm_default.c
hgomez 2004/02/13 00:46:37
Modified: jk/native2/common jk_vm_default.c
Log:
Make line longer but GCC more happy with it :)
Revision Changes Path
1.31 +2 -4 jakarta-tomcat-connectors/jk/native2/common/jk_vm_default.c
Index: jk_vm_default.c
===================================================================
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_vm_default.c,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -r1.30 -r1.31
--- jk_vm_default.c 30 Oct 2003 20:08:36 -0000 1.30
+++ jk_vm_default.c 13 Feb 2004 08:46:37 -0000 1.31
@@ -438,14 +438,12 @@
token = strtok(NULL, PATH_SEPARATOR_STR);
}
env->l->jkLog(env, env->l, JK_LOG_INFO,
- "jni.guessJvmDll() could not find %s in the " \
- "LD_LIBRARY_PATH\n",
+ "jni.guessJvmDll() could not find %s in the LD_LIBRARY_PATH\n",
jvm);
return NULL;
}
env->l->jkLog(env, env->l, JK_LOG_INFO,
- "jni.guessJvmDll() LD_LIBRARY_PATH " \
- "environment var is not set\n");
+ "jni.guessJvmDll() LD_LIBRARY_PATH environment var is not set\n");
return NULL;
#else
return jvm;
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_vm_default.c
Posted by Henri Gomez <hg...@apache.org>.
David Rees wrote:
> Henri Gomez wrote, On 2/13/2004 3:08 AM:
>
>>
>> Are you sure it will works on non gcc compiler ?
>>
>> I'd like to see Jean-Frederic opinion :) (exotic os/hardware)
>
>
> Does not look like it does, but at least now you'll know that if you're
> writing gcc specific code you can do it. ;-)
>
> The only non-gcc compiler I have access to is SGI's MIPSpro 7.2.1 where
> it does work there.
>
> Too bad not all compilers support it, it can make code a lot more readable.
In JK, we have to live with many OS and many compilers, Unixes (BSDs',
Linux's, AIX, HPUX, Solaris), Windows, Netware, OS400, BS2000, .....
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_vm_default.c
Posted by David Rees <dr...@greenhydrant.com>.
Henri Gomez wrote, On 2/13/2004 3:08 AM:
>
> Are you sure it will works on non gcc compiler ?
>
> I'd like to see Jean-Frederic opinion :) (exotic os/hardware)
Does not look like it does, but at least now you'll know that if you're
writing gcc specific code you can do it. ;-)
The only non-gcc compiler I have access to is SGI's MIPSpro 7.2.1 where
it does work there.
Too bad not all compilers support it, it can make code a lot more readable.
-Dave
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_vm_default.c
Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Henri Gomez wrote:
> David Rees wrote:
>
>> David Rees wrote, On 2/13/2004 1:14 AM:
>>
>>>
>>> If you want to use shorter lines, you can wrap long lines and still
>>> compile. For example (in case my patch gets stripped):
>>>
>>> printf("This is a ")
>>> "very long line.\n");
>>
>>
>>
>> Oops, my patch was reversed. Here's a good one.
>
>
> Are you sure it will works on non gcc compiler ?
>
> I'd like to see Jean-Frederic opinion :) (exotic os/hardware)
-1:
+++
bash-2.03$ make toto
cc -c -o toto.o toto.c
"toto.c", line 4: syntax error before or at: "very long line.\n"
cc: acomp failed for toto.c
make: *** [toto.o] Error 2
bash-2.03$ uname -a
SunOS PGTR0327 5.8 Generic_108528-13 sun4us sparc FJSV,GPUS
+++
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_vm_default.c
Posted by Henri Gomez <hg...@apache.org>.
David Rees wrote:
> David Rees wrote, On 2/13/2004 1:14 AM:
>
>>
>> If you want to use shorter lines, you can wrap long lines and still
>> compile. For example (in case my patch gets stripped):
>>
>> printf("This is a ")
>> "very long line.\n");
>
>
> Oops, my patch was reversed. Here's a good one.
Are you sure it will works on non gcc compiler ?
I'd like to see Jean-Frederic opinion :) (exotic os/hardware)
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_vm_default.c
Posted by David Rees <dr...@greenhydrant.com>.
David Rees wrote, On 2/13/2004 1:14 AM:
>
> If you want to use shorter lines, you can wrap long lines and still
> compile. For example (in case my patch gets stripped):
>
> printf("This is a ")
> "very long line.\n");
Oops, my patch was reversed. Here's a good one.
-Dave
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_vm_default.c
Posted by David Rees <dr...@greenhydrant.com>.
Henri,
If you want to use shorter lines, you can wrap long lines and still
compile. For example (in case my patch gets stripped):
printf("This is a ")
"very long line.\n");
-Dave
hgomez@apache.org wrote, On 2/13/2004 12:46 AM:
> hgomez 2004/02/13 00:46:37
>
> Modified: jk/native2/common jk_vm_default.c
> Log:
> Make line longer but GCC more happy with it :)
>
> Revision Changes Path
> 1.31 +2 -4 jakarta-tomcat-connectors/jk/native2/common/jk_vm_default.c
>
> Index: jk_vm_default.c
> ===================================================================
> RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_vm_default.c,v
> retrieving revision 1.30
> retrieving revision 1.31
> diff -u -r1.30 -r1.31
> --- jk_vm_default.c 30 Oct 2003 20:08:36 -0000 1.30
> +++ jk_vm_default.c 13 Feb 2004 08:46:37 -0000 1.31
> @@ -438,14 +438,12 @@
> token = strtok(NULL, PATH_SEPARATOR_STR);
> }
> env->l->jkLog(env, env->l, JK_LOG_INFO,
> - "jni.guessJvmDll() could not find %s in the " \
> - "LD_LIBRARY_PATH\n",
> + "jni.guessJvmDll() could not find %s in the LD_LIBRARY_PATH\n",
> jvm);
> return NULL;
> }
> env->l->jkLog(env, env->l, JK_LOG_INFO,
> - "jni.guessJvmDll() LD_LIBRARY_PATH " \
> - "environment var is not set\n");
> + "jni.guessJvmDll() LD_LIBRARY_PATH environment var is not set\n");
> return NULL;
> #else
> return jvm;