You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/30 17:02:17 UTC
[GitHub] [arrow] ianmcook opened a new pull request #9851: ARROW-12155: [R] Require Table columns to be same length
ianmcook opened a new pull request #9851:
URL: https://github.com/apache/arrow/pull/9851
This throws an error if the user attempts to create a Table with columns of different lengths. We already had this for RecordBatches but not for Tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #9851: ARROW-12155: [R] Require Table columns to be same length
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #9851:
URL: https://github.com/apache/arrow/pull/9851#discussion_r605919879
##########
File path: r/src/table.cpp
##########
@@ -327,6 +342,8 @@ std::shared_ptr<arrow::Table> Table__from_dots(SEXP lst, SEXP schema_sxp) {
StopIfNotOk(
arrow::r::CollectTableColumns(lst, schema, num_fields, infer_schema, columns));
+ StopIfNotOk(arrow::r::check_consistent_column_length(columns));
Review comment:
I believe this will conflict with https://github.com/apache/arrow/pull/9615/ but I believe the resolution is trivial: just insert this line as the second to last line in the new definition of `Table__from_dots`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #9851: ARROW-12155: [R] Require Table columns to be same length
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #9851:
URL: https://github.com/apache/arrow/pull/9851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #9851: ARROW-12155: [R] Require Table columns to be same length
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9851:
URL: https://github.com/apache/arrow/pull/9851#issuecomment-812648744
Nevermind I see that rebase won't help. I'll merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9851: ARROW-12155: [R] Require Table columns to be same length
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9851:
URL: https://github.com/apache/arrow/pull/9851#issuecomment-810728866
https://issues.apache.org/jira/browse/ARROW-12155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org