You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/05 18:04:44 UTC
[GitHub] [airflow] gardnerdev opened a new pull request #10190: Chart rbac modifications
gardnerdev opened a new pull request #10190:
URL: https://github.com/apache/airflow/pull/10190
I've tested it and in secured environments "ClusterRole" is often not allowed. What is the point of using here ClusterRole if for example in pod-cleanup-role.yaml is just a Role? It makes chart easier to use across corporations environements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on pull request #10190: Chart rbac modifications
Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #10190:
URL: https://github.com/apache/airflow/pull/10190#issuecomment-680863537
Hi,
I am also facing the same situation: we plan on letting users spawn airflow instances "on demand" on our dev k8s cluster, but we definitely don't plan on giving them rights to create `clusterRole`s.
I guess we can optionalize it in the `values.yaml` so that this chart fits in more environments while still being as capable as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #10190: Chart rbac modifications
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #10190:
URL: https://github.com/apache/airflow/pull/10190#issuecomment-680928660
Hi @gardnerdev, I think this is a good idea. Could you please make this a helm flag? I could see situations where either a role or a clusterrole would be correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman closed pull request #10190: Chart rbac modifications
Posted by GitBox <gi...@apache.org>.
dimberman closed pull request #10190:
URL: https://github.com/apache/airflow/pull/10190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aneesh-joseph commented on pull request #10190: Chart rbac modifications
Posted by GitBox <gi...@apache.org>.
aneesh-joseph commented on pull request #10190:
URL: https://github.com/apache/airflow/pull/10190#issuecomment-669949471
think that change was introduced to make the tests work (or to support multi namespaces?) - https://github.com/apache/airflow/pull/9468#discussion_r446619667
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gardnerdev commented on pull request #10190: Chart rbac modifications
Posted by GitBox <gi...@apache.org>.
gardnerdev commented on pull request #10190:
URL: https://github.com/apache/airflow/pull/10190#issuecomment-669953486
@aneesh-joseph makes sense. But imo it should be RoleBinding. It's really rare use-case of running in multinamespace envionment and makes the deployment harder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10190: Chart rbac modifications
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10190:
URL: https://github.com/apache/airflow/pull/10190#issuecomment-669347005
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #10190: Chart rbac modifications
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10190:
URL: https://github.com/apache/airflow/pull/10190#issuecomment-706789476
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org