You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Stefano Bagnara (JIRA)" <se...@james.apache.org> on 2008/01/14 22:35:34 UTC
[jira] Commented: (JAMES-833) ToMultiRepository doesn't resolve
repository_name correctly
[ https://issues.apache.org/jira/browse/JAMES-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558798#action_12558798 ]
Stefano Bagnara commented on JAMES-833:
---------------------------------------
I think this patch is wrong. I'm not sure at all that ToMultiRepository "is supposed" to get the local part of the username. I wrote it and I think I never intended it to parse the "@" in the username.
If the trailing / is missing then ok to add it, but I don't think that looking for the @ and getting the localpart is the right thing.
Virtual users support was one of the things in my mind when I changed LocalDelivery to be splitted in 2 classes.
> ToMultiRepository doesn't resolve repository_name correctly
> -----------------------------------------------------------
>
> Key: JAMES-833
> URL: https://issues.apache.org/jira/browse/JAMES-833
> Project: James
> Issue Type: Bug
> Components: Matchers/Mailets (bundled)
> Affects Versions: Trunk
> Environment: all
> Reporter: Kev Jackson
> Assignee: Norman Maurer
> Fix For: Trunk
>
> Attachments: ToMultiRepository.java.patch
>
>
> When using ToMultiRepository we noticed that it didn't store mails correctly - after turning on debugging for the mailstore log we saw items like:
> 10/01/08 03:59:02 DEBUG mailstore: Parsed URL: table = 'spamstomcat@test.intranet.freelance.com', repositoryName = 'null'
> This is because, although ToMultiRepository is supposed to just take the local part of the address for the repository name, it doesn't.
> There's also a problem caused by the current code not checking if the repositoryUrl value has a trailing '/' or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-833) ToMultiRepository doesn't
resolve repository_name correctly
Posted by Norman Maurer <no...@apache.org>.
Am Montag, den 14.01.2008, 22:56 +0100 schrieb Stefano Bagnara:
> Stefano Bagnara (JIRA) ha scritto:
> > [ https://issues.apache.org/jira/browse/JAMES-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558798#action_12558798 ]
> >
> > Stefano Bagnara commented on JAMES-833:
> > ---------------------------------------
> >
> > I think this patch is wrong. I'm not sure at all that ToMultiRepository "is supposed" to get the local part of the username. I wrote it and I think I never intended it to parse the "@" in the username.
> > If the trailing / is missing then ok to add it, but I don't think that looking for the @ and getting the localpart is the right thing.
> > Virtual users support was one of the things in my mind when I changed LocalDelivery to be splitted in 2 classes.
>
> Should we make the behaviour of ToMultiRepository in case of
> repositoryUrl parameter specified configurable so the user can choose
> whether to use only the local part or the full email address as
> repository_name ?
>
> Stefano
Ups, I had should think a bit more before apply the patch.
+1 for configuration opt.
bye
Norman
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-833) ToMultiRepository doesn't resolve
repository_name correctly
Posted by Stefano Bagnara <ap...@bago.org>.
Stefano Bagnara (JIRA) ha scritto:
> [ https://issues.apache.org/jira/browse/JAMES-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558798#action_12558798 ]
>
> Stefano Bagnara commented on JAMES-833:
> ---------------------------------------
>
> I think this patch is wrong. I'm not sure at all that ToMultiRepository "is supposed" to get the local part of the username. I wrote it and I think I never intended it to parse the "@" in the username.
> If the trailing / is missing then ok to add it, but I don't think that looking for the @ and getting the localpart is the right thing.
> Virtual users support was one of the things in my mind when I changed LocalDelivery to be splitted in 2 classes.
Should we make the behaviour of ToMultiRepository in case of
repositoryUrl parameter specified configurable so the user can choose
whether to use only the local part or the full email address as
repository_name ?
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org