You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/31 10:09:43 UTC
[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2889: fix: move setAllConnections to the right statement
e2corporation commented on code in PR #2889:
URL: https://github.com/apache/incubator-devlake/pull/2889#discussion_r959342247
##########
config-ui/src/hooks/useConnectionManager.jsx:
##########
@@ -393,38 +395,32 @@ function useConnectionManager (
)
console.log('>> ALL SOURCE CONNECTIONS: ', aC)
} else {
- c = await request.get(
+ const c = await request.get(
Review Comment:
This is better defined on `Ln 362` like it was before instead of declaring the variable within an IF block. This needs to get relocated back to 362 as `let c = null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org