You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Benjamin Lerer (JIRA)" <ji...@apache.org> on 2014/09/19 11:06:33 UTC
[jira] [Updated] (CASSANDRA-7981) Refactor SelectStatement
[ https://issues.apache.org/jira/browse/CASSANDRA-7981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Lerer updated CASSANDRA-7981:
--------------------------------------
Description:
The current state of the code of SelectStatement make fixing some issues or adding new functionnalities really hard. It also contains some functionnalities that we would like to reuse in ModificationStatement but cannot for the moment.
Ideally I would like to:
* Perform as much validation as possible on Relations instead of performing it on Restrictions as it will help for problem like the one of #CASSANDRA-6075 (I believe that by clearly separating validation and Restrictions building we will also make the code a lot clearer)
* Provide a way to easily merge restrictions on the same columns as needed for #CASSANDRA-7016
* Have a preparation logic (validation + pre-processing) that we can easily reuse for Delete statement #CASSANDRA-6237
* Make the code much easier to read and safer to modify.
was:
The current state of the code of SelectStatement make fixing some issues or adding new functionnalities really hard. It also contains some functionnalities that we would like to reuse in ModificationStatement but cannot for the moment.
Ideally I would like:
* Perform as much validation as possible on Relations instead of performing it on Restrictions as it will help for problem like the one of #CASSANDRA-6075 (I believe that by clearly separating validation and Restrictions building we will also make the code a lot clearer)
* Provide a way to easily merge restrictions on the same columns as needed for #CASSANDRA-7016
* Have a preparation logic (validation + pre-processing) that we can easily reuse for Delete statement #CASSANDRA-6237
* Make the code much easier to read and safer to modify.
> Refactor SelectStatement
> ------------------------
>
> Key: CASSANDRA-7981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7981
> Project: Cassandra
> Issue Type: Bug
> Reporter: Benjamin Lerer
> Assignee: Benjamin Lerer
> Fix For: 3.0
>
>
> The current state of the code of SelectStatement make fixing some issues or adding new functionnalities really hard. It also contains some functionnalities that we would like to reuse in ModificationStatement but cannot for the moment.
> Ideally I would like to:
> * Perform as much validation as possible on Relations instead of performing it on Restrictions as it will help for problem like the one of #CASSANDRA-6075 (I believe that by clearly separating validation and Restrictions building we will also make the code a lot clearer)
> * Provide a way to easily merge restrictions on the same columns as needed for #CASSANDRA-7016
> * Have a preparation logic (validation + pre-processing) that we can easily reuse for Delete statement #CASSANDRA-6237
> * Make the code much easier to read and safer to modify.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)