You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ti...@apache.org on 2020/09/03 11:26:51 UTC

[cordova-paramedic] branch feat/gh-actions updated: fix: adb

This is an automated email from the ASF dual-hosted git repository.

timbru31 pushed a commit to branch feat/gh-actions
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git


The following commit(s) were added to refs/heads/feat/gh-actions by this push:
     new 0c75665  fix: adb
0c75665 is described below

commit 0c7566585eed2c7fd96d354b6deedfe3c015945e
Author: Tim Brust <ti...@sinnerschrader.com>
AuthorDate: Thu Sep 3 13:26:38 2020 +0200

    fix: adb
---
 .github/workflows/android.yml | 1 +
 lib/utils/utilities.js        | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
index 05261b9..8c58691 100644
--- a/.github/workflows/android.yml
+++ b/.github/workflows/android.yml
@@ -48,6 +48,7 @@ jobs:
 
       - name: npm install and test
         run: |
+          export PATH="/usr/local/lib/android/sdk/platform-tools":$PATH
           npm i -g cordova
           npm ci
           node main.js --config ./pr/local/android-5.1.config.json  --plugin ./spec/testable-plugin/
diff --git a/lib/utils/utilities.js b/lib/utils/utilities.js
index ff62fb1..c68cd30 100644
--- a/lib/utils/utilities.js
+++ b/lib/utils/utilities.js
@@ -90,7 +90,7 @@ function getSimulatorModelId (cli, target) {
     const matchingSimulators = allSimulators.filter(i => i.match(target));
     if (!matchingSimulators.length) {
         logger.warn('Unable to find requested simulator, falling back to the first available!');
-        return allSimulators.filter(i => i.match(/^iPhone/)).pop().trim();
+        return allSimulators.filter(i => i.match(/^iPhone/))[0].trim();
     }
     return matchingSimulators
         .pop()


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org