You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by "Stefan Letz (JIRA)" <xe...@xml.apache.org> on 2005/01/20 17:05:17 UTC

[jira] Created: (XERCESC-1328) SAX2XMLReader::setFeature() handles feature use-cachedGrammarInParse incorrectly

SAX2XMLReader::setFeature() handles feature use-cachedGrammarInParse incorrectly
--------------------------------------------------------------------------------

         Key: XERCESC-1328
         URL: http://issues.apache.org/jira/browse/XERCESC-1328
     Project: Xerces-C++
        Type: Bug
  Components: SAX/SAX2  
    Versions: 2.6.0    
 Environment: RedHat Linux, kernel 2.4.20-18.9, xerces-c_2_6_0-redhat_80-gcc_32
    Reporter: Stefan Letz
    Priority: Minor


According to the documentation (SAX2 Programming Guide and Xerces-C++ Documentation), the setFeature() method of SAX2XMLReader is supposed to handle changes of the feature "http://apache.org/xml/features/validation/use-cachedGrammarInParse" as a no-op. Instead of doing so, it throws an exception, even if the feature is set to its current (valid) value.

In my eyes, setFeature() should throw a SAXNotSupportedException only if the user tries to set the feature to a value different from its current value, and do nothing otherwise.

If the implemented behavior is intended, the documentation should be updated accordingly.

Stefan Letz.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org


[jira] Commented: (XERCESC-1328) SAX2XMLReader::setFeature() handles feature use-cachedGrammarInParse incorrectly

Posted by "cargilld (JIRA)" <xe...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XERCESC-1328?page=comments#action_57843 ]
     
cargilld commented on XERCESC-1328:
-----------------------------------

The problem is that the predefined constant we used to check for this string has a typo in it...  Will make a fix shortly.

David

> SAX2XMLReader::setFeature() handles feature use-cachedGrammarInParse incorrectly
> --------------------------------------------------------------------------------
>
>          Key: XERCESC-1328
>          URL: http://issues.apache.org/jira/browse/XERCESC-1328
>      Project: Xerces-C++
>         Type: Bug
>   Components: SAX/SAX2
>     Versions: 2.6.0
>  Environment: RedHat Linux, kernel 2.4.20-18.9, xerces-c_2_6_0-redhat_80-gcc_32
>     Reporter: Stefan Letz
>     Priority: Minor

>
> According to the documentation (SAX2 Programming Guide and Xerces-C++ Documentation), the setFeature() method of SAX2XMLReader is supposed to handle changes of the feature "http://apache.org/xml/features/validation/use-cachedGrammarInParse" as a no-op. Instead of doing so, it throws an exception, even if the feature is set to its current (valid) value.
> In my eyes, setFeature() should throw a SAXNotSupportedException only if the user tries to set the feature to a value different from its current value, and do nothing otherwise.
> If the implemented behavior is intended, the documentation should be updated accordingly.
> Stefan Letz.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org


[jira] Resolved: (XERCESC-1328) SAX2XMLReader::setFeature() handles feature use-cachedGrammarInParse incorrectly

Posted by "cargilld (JIRA)" <xe...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XERCESC-1328?page=history ]
     
cargilld resolved XERCESC-1328:
-------------------------------

    Resolution: Fixed

I just checked in a fix to correct the spelling of the string defined by XMLUni::fgXercesUseCachedGrammarInParse (the letter
a was missing from Parse).  Please verify.

> SAX2XMLReader::setFeature() handles feature use-cachedGrammarInParse incorrectly
> --------------------------------------------------------------------------------
>
>          Key: XERCESC-1328
>          URL: http://issues.apache.org/jira/browse/XERCESC-1328
>      Project: Xerces-C++
>         Type: Bug
>   Components: SAX/SAX2
>     Versions: 2.6.0
>  Environment: RedHat Linux, kernel 2.4.20-18.9, xerces-c_2_6_0-redhat_80-gcc_32
>     Reporter: Stefan Letz
>     Priority: Minor

>
> According to the documentation (SAX2 Programming Guide and Xerces-C++ Documentation), the setFeature() method of SAX2XMLReader is supposed to handle changes of the feature "http://apache.org/xml/features/validation/use-cachedGrammarInParse" as a no-op. Instead of doing so, it throws an exception, even if the feature is set to its current (valid) value.
> In my eyes, setFeature() should throw a SAXNotSupportedException only if the user tries to set the feature to a value different from its current value, and do nothing otherwise.
> If the implemented behavior is intended, the documentation should be updated accordingly.
> Stefan Letz.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org


[jira] Commented: (XERCESC-1328) SAX2XMLReader::setFeature() handles feature use-cachedGrammarInParse incorrectly

Posted by "Stefan Letz (JIRA)" <xe...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XERCESC-1328?page=comments#action_58004 ]
     
Stefan Letz commented on XERCESC-1328:
--------------------------------------

Fix verified.

I suggest a change in the documentation of this feature, as the setting by the user is a no-op _only_ when the cache-grammarFromParse feature is true. To make this clear, the two sentences in the note field could be combined using "and".

> SAX2XMLReader::setFeature() handles feature use-cachedGrammarInParse incorrectly
> --------------------------------------------------------------------------------
>
>          Key: XERCESC-1328
>          URL: http://issues.apache.org/jira/browse/XERCESC-1328
>      Project: Xerces-C++
>         Type: Bug
>   Components: SAX/SAX2
>     Versions: 2.6.0
>  Environment: RedHat Linux, kernel 2.4.20-18.9, xerces-c_2_6_0-redhat_80-gcc_32
>     Reporter: Stefan Letz
>     Priority: Minor

>
> According to the documentation (SAX2 Programming Guide and Xerces-C++ Documentation), the setFeature() method of SAX2XMLReader is supposed to handle changes of the feature "http://apache.org/xml/features/validation/use-cachedGrammarInParse" as a no-op. Instead of doing so, it throws an exception, even if the feature is set to its current (valid) value.
> In my eyes, setFeature() should throw a SAXNotSupportedException only if the user tries to set the feature to a value different from its current value, and do nothing otherwise.
> If the implemented behavior is intended, the documentation should be updated accordingly.
> Stefan Letz.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org