You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/12 11:09:04 UTC
[GitHub] [superset] codemaster08240328 commented on a diff in pull request #19605: fix: Query execution time is displayed as invalid date
codemaster08240328 commented on code in PR #19605:
URL: https://github.com/apache/superset/pull/19605#discussion_r848310362
##########
superset-frontend/src/views/CRUD/data/query/QueryList.tsx:
##########
@@ -181,12 +181,9 @@ function QueryList({ addDangerToast, addSuccessToast }: QueryListProps) {
accessor: QueryObjectColumns.start_time,
Header: t('Time'),
size: 'xl',
- Cell: ({
- row: {
- original: { start_time, end_time },
- },
- }: any) => {
- const startMoment = moment.utc(start_time).local();
+ Cell: ({ row: { original } }: any) => {
+ const startTime = parseFloat(original.start_time);
Review Comment:
@diegomedina248 , I absolutely believe it works pretty well, but for just one confirmation.
Can you please check if the date field in text report to email is formatted correctly?
(Reason: It seems like by saving date in query result as a string, we resolved this issue in text report.)
Step:
1. Create a table chart including dates.
2. Create a report sending this chart as a report to email.
3. Date should be formatted as it appears in the chart.
The result we don't expect:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org