You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/03/27 00:06:54 UTC
[GitHub] [trafficserver] randall opened a new pull request #7634: statichit: misc. fixes
randall opened a new pull request #7634:
URL: https://github.com/apache/trafficserver/pull/7634
Anchor request to remapped path and allow for relative --file-paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall removed a comment on pull request #7634: statichit: misc. fixes
Posted by GitBox <gi...@apache.org>.
randall removed a comment on pull request #7634:
URL: https://github.com/apache/trafficserver/pull/7634#issuecomment-808786085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7634: statichit: misc. fixes
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7634:
URL: https://github.com/apache/trafficserver/pull/7634#issuecomment-809671999
Cherry-picked to v9.0.x branch.
Cherry-picked to v9.1.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on a change in pull request #7634: statichit: misc. fixes
Posted by GitBox <gi...@apache.org>.
randall commented on a change in pull request #7634:
URL: https://github.com/apache/trafficserver/pull/7634#discussion_r602643799
##########
File path: plugins/experimental/statichit/statichit.cc
##########
@@ -571,6 +571,14 @@ TSRemapDoRemap(void *ih, TSHttpTxn rh, TSRemapRequestInfo *rri)
return TSREMAP_NO_REMAP;
}
+ // Anchor to URL specified in remap
+ int pathsz;
+ TSUrlPathGet(rri->requestBufp, rri->requestUrl, &pathsz);
+ if (pathsz > 0) {
+ TSHttpTxnStatusSet(rh, TS_HTTP_STATUS_NOT_FOUND);
Review comment:
Thanks @shukitchan ! Added a VERROR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7634: statichit: misc. fixes
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7634:
URL: https://github.com/apache/trafficserver/pull/7634#issuecomment-808796249
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shukitchan commented on a change in pull request #7634: statichit: misc. fixes
Posted by GitBox <gi...@apache.org>.
shukitchan commented on a change in pull request #7634:
URL: https://github.com/apache/trafficserver/pull/7634#discussion_r602639755
##########
File path: plugins/experimental/statichit/statichit.cc
##########
@@ -571,6 +571,14 @@ TSRemapDoRemap(void *ih, TSHttpTxn rh, TSRemapRequestInfo *rri)
return TSREMAP_NO_REMAP;
}
+ // Anchor to URL specified in remap
+ int pathsz;
+ TSUrlPathGet(rri->requestBufp, rri->requestUrl, &pathsz);
+ if (pathsz > 0) {
+ TSHttpTxnStatusSet(rh, TS_HTTP_STATUS_NOT_FOUND);
Review comment:
Perhaps add an error message - VERROR("...");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7634: statichit: misc. fixes
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7634:
URL: https://github.com/apache/trafficserver/pull/7634#issuecomment-808786085
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall merged pull request #7634: statichit: misc. fixes
Posted by GitBox <gi...@apache.org>.
randall merged pull request #7634:
URL: https://github.com/apache/trafficserver/pull/7634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org