You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Andrew Kyle Purtell (Jira)" <ji...@apache.org> on 2022/07/01 20:44:00 UTC

[jira] [Updated] (HBASE-14127) Refactor AssignmentManager.unassign() function which has lots of return statements

     [ https://issues.apache.org/jira/browse/HBASE-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kyle Purtell updated HBASE-14127:
----------------------------------------
      Assignee:     (was: Apekshit Sharma)
    Resolution: Abandoned
        Status: Resolved  (was: Patch Available)

> Refactor AssignmentManager.unassign() function which has lots of return statements
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-14127
>                 URL: https://issues.apache.org/jira/browse/HBASE-14127
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Apekshit Sharma
>            Priority: Minor
>         Attachments: HBASE-14127-branch-1.patch, HBASE-14127-master-v2.patch, HBASE-14127-master.patch
>
>
> In AssignmentManager.unassign()
> * there are lots of return points
> * if condition is very non-trivial to understand
> * reuse of 'state' for different purpose makes things confusing
> A simple unfold of if-else with with better variable names should be sufficient.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)