[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3372: CIAB: remove tccache

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #3372: CIAB: remove tccache
URL: https://github.com/apache/trafficcontrol/pull/3372#discussion_r263063023
 
 

 ##########
 File path: infrastructure/cdn-in-a-box/docker-compose.yml
 ##########
 @@ -209,48 +209,36 @@ services:
       - variables.env
     hostname: trafficvault
 
-  # Apache Traffic Server (ATS) caches defined here
-  # base image from which all other caches inherit (builds and installs ATS+plugins)
-  tccache:
-    build:
-      context: ../..
-      dockerfile: infrastructure/cdn-in-a-box/cache/Dockerfile
-    image: tccache:latest
-
   # edge cache
   edge:
     privileged: True
     build:
-      context: .
-      dockerfile: edge/Dockerfile
-    depends_on:
-      - enroller
-      - tccache
+      context: ../..
+      dockerfile: infrastructure/cdn-in-a-box/cache/Dockerfile
     domainname: infra.ciab.test
     env_file:
       - variables.env
     hostname: edge
     volumes:
       - ./dns/set-dns.sh:/usr/local/sbin/set-dns.sh
       - ./dns/insert-self-into-dns.sh:/usr/local/sbin/insert-self-into-dns.sh
+      - ./edge/run.sh:/opt/init.d/99-run.sh
 
 Review comment:
   Why put this in `/opt/init.d` instead of just `/`? It seems like you're setting this up to run a bunch of scripts in a row, but there's only the one. If this was just added to container so that the `CMD` called it directly you could get rid of the whole `cache/run.sh` file you made to shell out calls to the real run script.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services