You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/14 06:09:35 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #10446: KAFKA-12661 ConfigEntry#equal does not compare other fields when value is NOT null

chia7712 commented on a change in pull request #10446:
URL: https://github.com/apache/kafka/pull/10446#discussion_r612961485



##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java
##########
@@ -149,24 +149,28 @@ public boolean equals(Object o) {
 
         ConfigEntry that = (ConfigEntry) o;
 
-        return this.name.equals(that.name) &&
-                this.value != null ? this.value.equals(that.value) : that.value == null &&

Review comment:
       @ijuma @dajac I filed a Jira for this PR as it includes a bug fix. Personally, it should be backport to all active branches. WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org