You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2024/08/02 17:30:24 UTC

Re: [PR] Improve test_version_format() error message for version mismatches [iceberg-python]

kevinjqliu commented on code in PR #991:
URL: https://github.com/apache/iceberg-python/pull/991#discussion_r1702131862


##########
tests/test_version.py:
##########
@@ -25,4 +25,8 @@ def test_version_format() -> None:
 
     assert (
         __version__ == installed_version
-    ), f"{__version__} <> {installed_version}, the installed version does not match with the current codebase"
+    ), (
+        f"{__version__} <> {installed_version}, the installed version does not match with the current codebase. "

Review Comment:
   ```suggestion
           f"The installed version ({installed_version}) does not match the current codebase version ({__version__})."
   ```
   
   What do you think of something like this, to make it clear which version is installed and which is current



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org