You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/08 15:34:54 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1693: sim/Make.defs: add -fvisibility=hidden to CFLAGS

xiaoxiang781216 commented on pull request #1693:
URL: https://github.com/apache/incubator-nuttx/pull/1693#issuecomment-688959129


   > @GUIDINGLI - just curious can you use --wrap or weak to accomplish this?
   
   1. The problem just exist in sim arch, it isn't good to add weak for the common code because the change will impact other arch.
   2. It's hard to predict what API the host software will call with the complex simulation(leaverage PC display, mouse, audio, usb etc),  which mean we need add all POSIX/libc/libc++ symbols to the list. This is a huge effort and an unmaintainable approach.
   The best method is directly disable host .so call into nuttx elf.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org