You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Sahlberg <da...@gmail.com> on 2026/07/28 07:29:03 UTC
Re: svn commit: r1936631 - in subversion/trunk: . subversion/tests/libsvn_fs_fs
Den mån 27 juli 2026 kl 12:48 skrev <iv...@apache.org>:
> Author: ivan
> Date: Mon Jul 27 10:48:05 2026
> New Revision: 1936631
>
...
> + /* Create 10 revisions. */
> + for (i = 1; i < 10; ++i)
> + {
> + svn_fs_txn_t *txn;
> + svn_fs_root_t *txn_root;
> + svn_revnum_t new_rev = 0;
> +
> + svn_pool_clear(iterpool);
> +
> + SVN_ERR(svn_fs_begin_txn(&txn, fs, new_rev, iterpool));
> + SVN_ERR(svn_fs_txn_root(&txn_root, txn, iterpool));
> + SVN_ERR(svn_fs_make_dir(txn_root, apr_itoa(pool, i), iterpool));
>
Is it intentional to use pool instead of iterpool in the call to apr_itoa?
Cheers,
Daniel
Re: svn commit: r1936631 - in subversion/trunk: . subversion/tests/libsvn_fs_fs
Posted by Ivan Zhakov <iv...@apache.org>.
On Tue, 28 Jul 2026 at 10:29, Daniel Sahlberg <da...@gmail.com>
wrote:
> Den mån 27 juli 2026 kl 12:48 skrev <iv...@apache.org>:
>
>> Author: ivan
>> Date: Mon Jul 27 10:48:05 2026
>> New Revision: 1936631
>>
>
> ...
>
>> + /* Create 10 revisions. */
>> + for (i = 1; i < 10; ++i)
>> + {
>> + svn_fs_txn_t *txn;
>> + svn_fs_root_t *txn_root;
>> + svn_revnum_t new_rev = 0;
>> +
>> + svn_pool_clear(iterpool);
>> +
>> + SVN_ERR(svn_fs_begin_txn(&txn, fs, new_rev, iterpool));
>> + SVN_ERR(svn_fs_txn_root(&txn_root, txn, iterpool));
>> + SVN_ERR(svn_fs_make_dir(txn_root, apr_itoa(pool, i), iterpool));
>>
>
> Is it intentional to use pool instead of iterpool in the call to apr_itoa?
>
>
No, it was not intentional. I copied this code from other test and didn't
check it properly.
Fixed in r1936661 <https://svn.apache.org/r1936661>.
And I also fixed the code I copied from in r1936662
<https://svn.apache.org/r1936662>.
Thanks!
--
Ivan Zhakov