You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2015/05/14 18:08:53 UTC
[GitHub] activemq-artemis pull request: Changing host to 0.0.0.0
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/261
Changing host to 0.0.0.0
We are changing the default host to 0.0.0.0 per feedback from the community (activemq dev-list)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-6 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/261.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #261
----
commit 3085778e4e3360d0249c12d2364ba21d2248d78a
Author: Clebert Suconic <cl...@apache.org>
Date: 2015-05-14T16:02:43Z
Changing host to 0.0.0.0
We are changing the default host to 0.0.0.0 per feedback from the community (activemq dev-list)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Changing host to 0.0.0.0
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/261#issuecomment-103527523
@clebertsuconic I checked the license guide here: http://www.apache.org/legal/src-headers.html
Given the nature of the file in question, a case could be made for it to come under this section:
WHAT FILES IN AN APACHE RELEASE DO NOT REQUIRE A LICENSE HEADER?
A file without any degree of creativity in either its literal elements or its structure is not protected by copyright law; therefore, such a file does not require a license header. If in doubt about the extent of the file's creativity, add the license header to the file.
For this reason I think you are safe in ignoring the license header on this file. Particularly due to the difficulty in removing the header during the templating process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: NullPointerException when trying to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Changing host to 0.0.0.0
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/pull/261#issuecomment-103507298
I also think the password should be masked if possible and the docs should be updated.
Also, it might be good for there to be some kind of simple explanation at the beginning of the set-up process. Something like, "Please answer the following questions to complete the initial security configuration for the broker."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Changing host to 0.0.0.0
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/261#issuecomment-103496660
This is not supposed to have a license header... it's just what's the inside option that will be placed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Changing host to 0.0.0.0
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/261#issuecomment-103483341
I really like what you have done here @clebertsuconic.
Just a couple of minor things.
1. Could you please change the text to identify what type of user will be created, default, admin, initial etc...? i.e.
# Please enter [default,admin,initial] username ->
martyn
2. Can the password be hidden i.e.:
# Password ->
***********
3. Could you also add some instructions to the README that just explain what these options mean.
Thanks.
I've tested this on linux and windows and works fine.
Cheers
Martyn
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Changing host to 0.0.0.0
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the pull request:
https://github.com/apache/activemq-artemis/pull/261#issuecomment-103563394
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Changing host to 0.0.0.0
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Changing host to 0.0.0.0
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/261#issuecomment-103560099
+1 from me. I will leave for @jbertram to +1 before merging, Cheers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---