You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "reuvenlax (via GitHub)" <gi...@apache.org> on 2026/10/06 20:51:59 UTC
[PR] Add PipelineOptions changes for merging ValidatesRunner tests. [beam]
reuvenlax opened a new pull request, #40437:
URL: https://github.com/apache/beam/pull/40437
When merging ValidatesRunner tests, we need to ensure that pipelines with differing PipelineOptions (including and PIpelineOptions subclass) are not merged together. This simple approach of just serializing the options (MAPPER.valueToTree(options).get("options")), however that contains _every_ bound value. As a result, two options objects configured identically can serialize differently depending purely on which getters happened to be called on each — e.g. View.asList() and Reshuffle read updateCompatibilityVersion during construction, and GcsFileSystem reads gcsPerformanceMetrics, so a pipeline that uses them "has" those keys and one that doesn't, doesn't. In these cases the getters simply return the default values, so the PipelineOptions are logically the same.
There is a BoundValue.isDefault bit (private) that one might try to use to solve this problem, by excluding default-values from the comparison. However testing often roundtrips options through JSON, after which this isDefault bit is lost.
This PR introduces PipelineOptionsFactory.explicitlySetProperties(PipelineOptions) which returns the names of properties that have been explicitly set. In order to maintain things across roundtrips, we introduce a new field in the serialized JSON to track any fields that have lazily-bound defaults. This is currently not enabled in production pipelines - it's only enabled by TestPipeline.java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add PipelineOptions changes for merging ValidatesRunner tests. [beam]
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax merged PR #40437:
URL: https://github.com/apache/beam/pull/40437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add PipelineOptions changes for merging ValidatesRunner tests. [beam]
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax commented on PR #40437:
URL: https://github.com/apache/beam/pull/40437#issuecomment-6130190654
@kennknowles friendly ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add PipelineOptions changes for merging ValidatesRunner tests. [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40437:
URL: https://github.com/apache/beam/pull/40437#issuecomment-6027880028
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/40437?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `86.95652%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.74%. Comparing base ([`69bdf5f`](https://app.codecov.io/gh/apache/beam/commit/69bdf5f29174adebe19006e1397acd6681ffce9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`70a91b9`](https://app.codecov.io/gh/apache/beam/commit/70a91b9f34fd242d8c51695eb713b2fae9e3a9eb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 27 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/beam/pull/40437?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...pache/beam/sdk/options/PipelineOptionsFactory.java](https://app.codecov.io/gh/apache/beam/pull/40437?src=pr&el=tree&filepath=sdks%2Fjava%2Fcore%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbeam%2Fsdk%2Foptions%2FPipelineOptionsFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9qYXZhL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JlYW0vc2RrL29wdGlvbnMvUGlwZWxpbmVPcHRpb25zRmFjdG9yeS5qYXZh) | 71.42% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/beam/pull/40437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/beam/sdk/options/ProxyInvocationHandler.java](https://app.codecov.io/gh/apache/beam/pull/40437?src=pr&el=tree&filepath=sdks%2Fjava%2Fcore%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbeam%2Fsdk%2Foptions%2FProxyInvocationHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9qYXZhL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JlYW0vc2RrL29wdGlvbnMvUHJveHlJbnZvY2F0aW9uSGFuZGxlci5qYXZh) | 93.54% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/beam/pull/40437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/beam/sdk/testing/TestPipeline.java](https://app.codecov.io/gh/apache/beam/pull/40437?src=pr&el=tree&filepath=sdks%2Fjava%2Fcore%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbeam%2Fsdk%2Ftesting%2FTestPipeline.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9qYXZhL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JlYW0vc2RrL3Rlc3RpbmcvVGVzdFBpcGVsaW5lLmphdmE=) | 75.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/40437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40437 +/- ##
============================================
- Coverage 59.04% 58.74% -0.30%
+ Complexity 15624 13911 -1713
============================================
Files 2797 2583 -214
Lines 280750 271479 -9271
Branches 12488 11240 -1248
============================================
- Hits 165764 159491 -6273
+ Misses 108540 105990 -2550
+ Partials 6446 5998 -448
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/40437/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [java](https://app.codecov.io/gh/apache/beam/pull/40437/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.25% <86.95%> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/40437?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add PipelineOptions changes for merging ValidatesRunner tests. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40437:
URL: https://github.com/apache/beam/pull/40437#issuecomment-6027175430
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add PipelineOptions changes for merging ValidatesRunner tests. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40437:
URL: https://github.com/apache/beam/pull/40437#issuecomment-6028380659
Assigning reviewers:
R: @chamikaramj for label java.
This pull request likely touches a core component ("core" label). Please review with scrutiny.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org