You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-commits@lucene.apache.org by dn...@apache.org on 2005/05/06 00:37:11 UTC
svn commit: r168450 - in /lucene/java/trunk/src/java/org/apache/lucene:
index/SegmentMerger.java search/MultiPhraseQuery.java
search/MultiSearcher.java search/PhrasePrefixQuery.java
search/PhraseQuery.java search/TermQuery.java
Author: dnaber
Date: Thu May 5 15:37:09 2005
New Revision: 168450
URL: http://svn.apache.org/viewcvs?rev=168450&view=rev
Log:
don't declare Exceptions that are never thrown; remove an unused variable
Modified:
lucene/java/trunk/src/java/org/apache/lucene/index/SegmentMerger.java
lucene/java/trunk/src/java/org/apache/lucene/search/MultiPhraseQuery.java
lucene/java/trunk/src/java/org/apache/lucene/search/MultiSearcher.java
lucene/java/trunk/src/java/org/apache/lucene/search/PhrasePrefixQuery.java
lucene/java/trunk/src/java/org/apache/lucene/search/PhraseQuery.java
lucene/java/trunk/src/java/org/apache/lucene/search/TermQuery.java
Modified: lucene/java/trunk/src/java/org/apache/lucene/index/SegmentMerger.java
URL: http://svn.apache.org/viewcvs/lucene/java/trunk/src/java/org/apache/lucene/index/SegmentMerger.java?rev=168450&r1=168449&r2=168450&view=diff
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/index/SegmentMerger.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/index/SegmentMerger.java Thu May 5 15:37:09 2005
@@ -365,7 +365,7 @@
private long lastSkipFreqPointer;
private long lastSkipProxPointer;
- private void resetSkip() throws IOException {
+ private void resetSkip() {
skipBuffer.reset();
lastSkipDoc = 0;
lastSkipFreqPointer = freqOutput.getFilePointer();
Modified: lucene/java/trunk/src/java/org/apache/lucene/search/MultiPhraseQuery.java
URL: http://svn.apache.org/viewcvs/lucene/java/trunk/src/java/org/apache/lucene/search/MultiPhraseQuery.java?rev=168450&r1=168449&r2=168450&view=diff
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/search/MultiPhraseQuery.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/search/MultiPhraseQuery.java Thu May 5 15:37:09 2005
@@ -130,7 +130,7 @@
public Query getQuery() { return MultiPhraseQuery.this; }
public float getValue() { return value; }
- public float sumOfSquaredWeights() throws IOException {
+ public float sumOfSquaredWeights() {
queryWeight = idf * getBoost(); // compute query weight
return queryWeight * queryWeight; // square it
}
Modified: lucene/java/trunk/src/java/org/apache/lucene/search/MultiSearcher.java
URL: http://svn.apache.org/viewcvs/lucene/java/trunk/src/java/org/apache/lucene/search/MultiSearcher.java?rev=168450&r1=168449&r2=168450&view=diff
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/search/MultiSearcher.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/search/MultiSearcher.java Thu May 5 15:37:09 2005
@@ -56,7 +56,7 @@
return df;
}
- public int[] docFreqs(Term[] terms) throws IOException {
+ public int[] docFreqs(Term[] terms) {
int[] result = new int[terms.length];
for (int i = 0; i < terms.length; i++) {
result[i] = docFreq(terms[i]);
@@ -68,7 +68,7 @@
return maxDoc;
}
- public Query rewrite(Query query) throws IOException {
+ public Query rewrite(Query query) {
// this is a bit of a hack. We know that a query which
// creates a Weight based on this Dummy-Searcher is
// always already rewritten (see preparedWeight()).
@@ -76,27 +76,27 @@
return query;
}
- public void close() throws IOException {
+ public void close() {
throw new UnsupportedOperationException();
}
- public Document doc(int i) throws IOException{
+ public Document doc(int i) {
throw new UnsupportedOperationException();
}
- public Explanation explain(Weight weight,int doc) throws IOException {
+ public Explanation explain(Weight weight,int doc) {
throw new UnsupportedOperationException();
}
- public void search(Weight weight, Filter filter, HitCollector results) throws IOException {
+ public void search(Weight weight, Filter filter, HitCollector results) {
throw new UnsupportedOperationException();
}
- public TopDocs search(Weight weight,Filter filter,int n) throws IOException {
+ public TopDocs search(Weight weight,Filter filter,int n) {
throw new UnsupportedOperationException();
}
- public TopFieldDocs search(Weight weight,Filter filter,int n,Sort sort) throws IOException {
+ public TopFieldDocs search(Weight weight,Filter filter,int n,Sort sort) {
throw new UnsupportedOperationException();
}
};
Modified: lucene/java/trunk/src/java/org/apache/lucene/search/PhrasePrefixQuery.java
URL: http://svn.apache.org/viewcvs/lucene/java/trunk/src/java/org/apache/lucene/search/PhrasePrefixQuery.java?rev=168450&r1=168449&r2=168450&view=diff
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/search/PhrasePrefixQuery.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/search/PhrasePrefixQuery.java Thu May 5 15:37:09 2005
@@ -131,7 +131,7 @@
public Query getQuery() { return PhrasePrefixQuery.this; }
public float getValue() { return value; }
- public float sumOfSquaredWeights() throws IOException {
+ public float sumOfSquaredWeights() {
queryWeight = idf * getBoost(); // compute query weight
return queryWeight * queryWeight; // square it
}
Modified: lucene/java/trunk/src/java/org/apache/lucene/search/PhraseQuery.java
URL: http://svn.apache.org/viewcvs/lucene/java/trunk/src/java/org/apache/lucene/search/PhraseQuery.java?rev=168450&r1=168449&r2=168450&view=diff
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/search/PhraseQuery.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/search/PhraseQuery.java Thu May 5 15:37:09 2005
@@ -119,7 +119,7 @@
public Query getQuery() { return PhraseQuery.this; }
public float getValue() { return value; }
- public float sumOfSquaredWeights() throws IOException {
+ public float sumOfSquaredWeights() {
queryWeight = idf * getBoost(); // compute query weight
return queryWeight * queryWeight; // square it
}
Modified: lucene/java/trunk/src/java/org/apache/lucene/search/TermQuery.java
URL: http://svn.apache.org/viewcvs/lucene/java/trunk/src/java/org/apache/lucene/search/TermQuery.java?rev=168450&r1=168449&r2=168450&view=diff
==============================================================================
--- lucene/java/trunk/src/java/org/apache/lucene/search/TermQuery.java (original)
+++ lucene/java/trunk/src/java/org/apache/lucene/search/TermQuery.java Thu May 5 15:37:09 2005
@@ -31,7 +31,6 @@
private class TermWeight implements Weight {
private Similarity similarity;
- private Searcher searcher;
private float value;
private float idf;
private float queryNorm;
@@ -48,7 +47,7 @@
public Query getQuery() { return TermQuery.this; }
public float getValue() { return value; }
- public float sumOfSquaredWeights() throws IOException {
+ public float sumOfSquaredWeights() {
queryWeight = idf * getBoost(); // compute query weight
return queryWeight * queryWeight; // square it
}
Re: svn commit: r168450 - in /lucene/java/trunk/src/java/org/apache/lucene: index/SegmentMerger.java search/MultiPhraseQuery.java search/MultiSearcher.java search/PhrasePrefixQuery.java search/PhraseQuery.java search/TermQuery.java
Posted by Daniel Naber <lu...@danielnaber.de>.
On Friday 06 May 2005 20:00, Doug Cutting wrote:
> When these are implementing a pubic interface or abstract method I think
> it is good to keep the exception declaration, as it is a part of the
> interface.
Yes, I'm aware of that. All my changes (unless I made a mistake) only
affected private or final methods or methods inside inner private classes.
Regards
Daniel
--
http://www.danielnaber.de
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: svn commit: r168450 - in /lucene/java/trunk/src/java/org/apache/lucene:
index/SegmentMerger.java search/MultiPhraseQuery.java search/MultiSearcher.java
search/PhrasePrefixQuery.java search/PhraseQuery.java search/TermQuery.java
Posted by Doug Cutting <cu...@apache.org>.
dnaber@apache.org wrote:
> don't declare Exceptions that are never thrown; remove an unused variable
When these are implementing a pubic interface or abstract method I think
it is good to keep the exception declaration, as it is a part of the
interface. That way, if an exception needs to be thrown in the future,
the developer knows what types are permitted.
Doug
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org