You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitin-maharana <gi...@git.apache.org> on 2016/11/24 12:04:11 UTC

[GitHub] cloudstack pull request #1778: CLOUDSTACK-9613: Unable to set NAT rules on a...

GitHub user nitin-maharana opened a pull request:

    https://github.com/apache/cloudstack/pull/1778

    CLOUDSTACK-9613: Unable to set NAT rules on any interfaces except first interface of VM.

    Description:
    =========
    VMs have multiple network interfaces.
    It is not possible to set a NAT rule on any of the interfaces except the first interface of the VM from UI. Because the UI only lists the IPs of the first interface.
    
    The rules can only be set on the "default" interface but even after setting the secondary as the default interface the outcome is still the same. Only the first interface is listed in the UI as available for setting NAT rules.
    
    Steps to Reproduce:
    ===============
    1. Create two networks.
    2. Create a VM.
    3. Attach both the networks to the VM.
    4. Create NAT rules using both the networks.
    5. Observe the add VM section while creating the rule.
    6. The same IPs appear for both the case.
    
    Please see the below snaps to observe the issue clearly.
    
    VM NIC1
    ![image](https://cloud.githubusercontent.com/assets/12583725/20597703/4a1df876-b26b-11e6-9f49-5488f587315f.png)
    
    VM NIC2
    ![image](https://cloud.githubusercontent.com/assets/12583725/20597724/64447ce8-b26b-11e6-8504-7c1e1723eeea.png)
    
    Creating NAT rule from Network-1
    ![image](https://cloud.githubusercontent.com/assets/12583725/20597740/7a49b440-b26b-11e6-8127-948f547adb01.png)
    
    Add VMs section
    ![image](https://cloud.githubusercontent.com/assets/12583725/20597766/94e1164a-b26b-11e6-95f0-cd9cd361ba4d.png)
    
    Creating NAT rule from Network-2
    ![image](https://cloud.githubusercontent.com/assets/12583725/20597775/a11af656-b26b-11e6-93c5-0b55e434d788.png)
    
    Add VMs section
    ![image](https://cloud.githubusercontent.com/assets/12583725/20597779/a6684992-b26b-11e6-9671-743870a096e6.png)
    
    Expected:
    ========
    
    Add VMs section from Network-1
    ![image](https://cloud.githubusercontent.com/assets/12583725/20597858/1c31d120-b26c-11e6-9d77-396177c66999.png)
    
    
    Add VMs section from Network-2
    ![image](https://cloud.githubusercontent.com/assets/12583725/20597850/0dcc5a1a-b26c-11e6-9b42-67fc6a3e19c1.png)
    
    Resolution:
    ========
    Instead of always passing the id of the first nic, passing the id of
    the nic which is on the same network as the IP address of which
    we are enabling port-forwarding/load-balancing.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1778
    
----
commit 83f4cb1598a4786dafbee3a975a88918f8f7381f
Author: Nitin Kumar Maharana <ni...@accelerite.com>
Date:   2016-11-24T11:45:40Z

    CLOUDSTACK-9613: Unable to set NAT rules on any interfaces except first interface of VM.
    
    Instead of always passing the id of the first nic, passing the id of
    the nic which is on the same network as the IP address on which
    we are enabling port-fprwarding/load-balancing.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1778: CLOUDSTACK-9613: Unable to set NAT rules on any inte...

Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:

    https://github.com/apache/cloudstack/pull/1778
  
    @nitin-maharana so I suggest to use "networkId" instead of nicId, it is simpler change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1778: CLOUDSTACK-9613: Unable to set NAT rules on any inte...

Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:

    https://github.com/apache/cloudstack/pull/1778
  
    @nitin-maharana Hi Nitin, can we use "networkId: network.id" instead nicId ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1778: CLOUDSTACK-9613: Unable to set NAT rules on any inte...

Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:

    https://github.com/apache/cloudstack/pull/1778
  
    @ustcweizhou : I made the changes. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1778: CLOUDSTACK-9613: Unable to set NAT rules on any inte...

Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:

    https://github.com/apache/cloudstack/pull/1778
  
    @ustcweizhou : Yes, we can directly pass networkid instead nicId. They handled the same way in case of multiple vm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1778: CLOUDSTACK-9613: Unable to set NAT rules on a...

Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana closed the pull request at:

    https://github.com/apache/cloudstack/pull/1778


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1778: CLOUDSTACK-9613: Unable to set NAT rules on any inte...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1778
  
    Thanks @nitin-maharana a similar fix was merged with #1785 since it was for 4.9. Please close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---