[GitHub] [submarine] pingsutw commented on a change in pull request #368: SUBMARINE-585. [WEB] Edit existing experiments through UI

[GitBox <gi...@apache.org>]

pingsutw commented on a change in pull request #368:
URL: https://github.com/apache/submarine/pull/368#discussion_r464143584



##########
File path: submarine-workbench/workbench-web-ng/proxy.conf.js
##########
@@ -24,13 +24,13 @@ dotenv.config();
 const proxyConfig = [
   {
     context: ['/api'],
-    target: 'http://localhost:8080',
+    target: 'http://submarine:8080',

Review comment:
       ```suggestion
       target: 'http://localhost:8080',
   ```

##########
File path: submarine-workbench/workbench-web-ng/proxy.conf.js
##########
@@ -24,13 +24,13 @@ dotenv.config();
 const proxyConfig = [
   {
     context: ['/api'],
-    target: 'http://localhost:8080',
+    target: 'http://submarine:8080',
     secure: false,
     changeOrigin: true
   },
   {
     context: '/ws',
-    target: 'ws://localhost:8080',
+    target: 'ws://submarine:8080',

Review comment:
       ```suggestion
       target: 'ws://localhost:8080',
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org