You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by chenerlu <gi...@git.apache.org> on 2018/03/04 15:42:47 UTC

[GitHub] carbondata pull request #2029: [CARBONDATA-2222] Update the FAQ doc for some...

GitHub user chenerlu opened a pull request:

    https://github.com/apache/carbondata/pull/2029

    [CARBONDATA-2222] Update the FAQ doc for some mistakes

    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [No] Any interfaces changed?
     
     - [No] Any backward compatibility impacted?
     
     - [Yes ] Document update required?
    
     - [NA ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ NA] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chenerlu/incubator-carbondata updatedoc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2029.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2029
    
----
commit e10ed2c0d96070112bb5701ba85b896fb6fe1f18
Author: chenerlu <ch...@...>
Date:   2018-03-04T15:39:40Z

    update the FAQ doc for some mistakes

----


---

[GitHub] carbondata issue #2029: [CARBONDATA-2222] Update the FAQ doc for some mistak...

Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/2029
  
    LGTM


---

[GitHub] carbondata issue #2029: [CARBONDATA-2222] Update the FAQ doc for some mistak...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2029
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3760/



---

[GitHub] carbondata issue #2029: [CARBONDATA-2222] Update the FAQ doc for some mistak...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2029
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4066/



---

[GitHub] carbondata pull request #2029: [CARBONDATA-2222] Update the FAQ doc for some...

Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2029#discussion_r172160130
  
    --- Diff: docs/faq.md ---
    @@ -143,38 +143,38 @@ INSERT INTO TABLE carbon_table SELECT id, city FROM source_table;
     When the column type in carbon table is different from the column specified in select statement. The insert operation will still success, but you may get NULL in result, because NULL will be substitute value when conversion type failed.
     
     ## Why aggregate query is not fetching data from aggregate table?
    -Following are the aggregate queries that won’t fetch data from aggregate table:
    +Following are the aggregate queries that won't fetch data from aggregate table:
     
     - **Scenario 1** :
     When SubQuery predicate is present in the query.
     
    -Example 
    +Example:
     
     ```
    -create table gdp21(cntry smallint, gdp double, y_year date) stored by 'carbondata'
    -create datamap ag1 on table gdp21 using 'preaggregate' as select cntry, sum(gdp) from gdp group by ctry;
    -select ctry from pop1 where ctry in (select cntry from gdp21 group by cntry)
    +create table gdp21(cntry smallint, gdp double, y_year date) stored by 'carbondata';
    --- End diff --
    
    remove `;`


---

[GitHub] carbondata issue #2029: [CARBONDATA-2222] Update the FAQ doc for some mistak...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2029
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2820/



---

[GitHub] carbondata pull request #2029: [CARBONDATA-2222] Update the FAQ doc for some...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2029


---