You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/15 05:30:38 UTC

[GitHub] [spark] manuzhang commented on a diff in pull request #36658: [SPARK-39278][CORE] Fix backward compatibility of alternative configs of Hadoop Filesystems to access

manuzhang commented on code in PR #36658:
URL: https://github.com/apache/spark/pull/36658#discussion_r897550040


##########
core/src/test/scala/org/apache/spark/SparkConfSuite.scala:
##########
@@ -277,8 +277,11 @@ class SparkConfSuite extends SparkFunSuite with LocalSparkContext with ResetSyst
     conf.set("spark.yarn.access.namenodes", "testNode")
     assert(conf.get(KERBEROS_FILESYSTEMS_TO_ACCESS) === Array("testNode"))
 
-    conf.set("spark.yarn.access.hadoopFileSystems", "testNode")

Review Comment:
   I'd like to point out this test is meaningless before this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org