[jira] [Commented] (BEAM-2272) Test scope & runtime dependencies need reevaluation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070985#comment-16070985 ] 

ASF GitHub Bot commented on BEAM-2272:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3487

    [BEAM-2272] Enforce dependency convergence

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    This changes the global config. Opening a PR to see which modules include the enforcer plugin but have divergent deps.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam enforcer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3487.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3487
    
----
commit 47a0f3775ff700be7358ed9d1d3948d892db4a8f
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-07-01T04:12:54Z

    Enforce dependency convergence

----


> Test scope & runtime dependencies need reevaluation
> ---------------------------------------------------
>
>                 Key: BEAM-2272
>                 URL: https://issues.apache.org/jira/browse/BEAM-2272
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow, runner-direct, sdk-java-core
>            Reporter: Daniel Halperin
>            Assignee: Kenneth Knowles
>             Fix For: 2.1.0
>
>
> Now that SDK core has been thinned out, many of the modules that have it in their {{dependenciesToScan}} will need to update their test-scoped dependencies for things that moved out of SDK.
> Known examples include protobuf and XML and perhaps others.
> We should re-enable dependency analysis on test scope and manually validate and ignore specific known runtime/test-runtime dependencies.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)