You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/07/29 14:14:50 UTC
[GitHub] rabbah commented on a change in pull request #3806: add register
and until to ansible invoker pull runtime images tasks
rabbah commented on a change in pull request #3806: add register and until to ansible invoker pull runtime images tasks
URL: https://github.com/apache/incubator-openwhisk/pull/3806#discussion_r205975575
##########
File path: ansible/roles/controller/tasks/deploy.yml
##########
@@ -13,10 +13,10 @@
"{{ (controller_index_base|int) + host_group.index(inventory_hostname) }}"
- name: "pull the {{ docker.image.tag }} image of controller"
- shell:
- docker pull
- {{ docker_registry~docker.image.prefix }}/controller:{{docker.image.tag}}
+ shell: "docker pull {{docker_registry}}{{ docker.image.prefix }}/controller:{{docker.image.tag}}"
when: docker_registry != ""
+ register: result
+ until: (result.rc == 0)
Review comment:
this is too broad --- if the image isn't found, this will retry 10 times to no avail. Can we restrict the error code for network failures instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services