You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/02/06 19:22:47 UTC

[GitHub] [incubator-mxnet] olk opened a new pull request #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

olk opened a new pull request #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536
 
 
   ## Description ##
   (Brief description on what this PR is about)
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583282951
 
 
   There was an additional whitespace error from a previous commit - I don't know why it could pass the lint check.
   I've adopted my vimrc accordingly.
   
   Could I get a link to the coding/code formatting standards used by MXNet?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] olk commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
olk commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583383270
 
 
   generating Julia docs fails with:
   ```
   [2020-02-07T10:19:19.325Z] raise VersionConflict(dist, req).with_context(dependent_req)
   [2020-02-07T10:19:19.325Z] pkg_resources.VersionConflict: (Markdown 3.2 (/home/jenkins_slave/.local/lib/python3.5/site-packages), Requirement.parse('markdown<3.2'))
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] olk closed pull request #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
olk closed pull request #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583149878
 
 
   `[2020-02-06T20:48:22.104Z] include/mxnet/lib_api.h:631:  Lines should be <= 100 characters long  [whitespace/line_length] [2]
   `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583070375
 
 
   Please see CI, lint is failing:
   
   `[2020-02-06T19:25:21.265Z] include/mxnet/lib_api.h: 1 Errors of 1 Categories map={'whitespace': 1}
   `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583383270
 
 
   generating Julia docs fails with:
   ```
   [2020-02-07T10:19:19.325Z] raise VersionConflict(dist, req).with_context(dependent_req)
   [2020-02-07T10:19:19.325Z] pkg_resources.VersionConflict: (Markdown 3.2 (/home/jenkins_slave/.local/lib/python3.5/site-packages), Requirement.parse('markdown<3.2'))
   ```
   Seams to be an problem of the build system.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583101224
 
 
   whitespace error was introduced by another commit
   
   > ae472c266 dynamic custom operator support (#15921)
   
    I've fixed it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583282951
 
 
   There was an additional whitespace error from a previous commit - I don't know why it could pass the lint check.
   I've adopted my vimrc accordingly.
   
   Could I get a link to the coding/code formating standards used by MXNet?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] olk commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
olk commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583101224
 
 
   whitespace error was introduced by commit ae472c266 dynamic custom operator support (#15921) - I've fixed it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
leezu edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583149878
 
 
   `[2020-02-06T20:48:22.104Z] include/mxnet/lib_api.h:631:  Lines should be <= 100 characters long  [whitespace/line_length] [2]
   `
   
   Sorry, I didn't paste the exact error message but only the error summary before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
olk edited a comment on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583101224
 
 
   whitespace error was introduced by commit
   
   > ae472c266 dynamic custom operator support (#15921)
   
    I've fixed it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] olk commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal

Posted by GitBox <gi...@apache.org>.
olk commented on issue #17536: MXNET-1444/MXNET-1445: replace NULL by nullptr literal
URL: https://github.com/apache/incubator-mxnet/pull/17536#issuecomment-583282951
 
 
   There was an additional whitespace error from a previous commit - I don't know why it could pass the lint check.
   I've adopted my vimrc accordingly.
   
   Could I get a link to the coding/code formating standards used in MXNet?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services